Skip to content

Commit

Permalink
fix: always keep ui-kit poppers visible
Browse files Browse the repository at this point in the history
we have a situation in that SOME osx users don't see tooltips and the dependency
toggle on the services form.

this is a workaround that always keeps poppers visible - where they would
usually be hidden once their reference elements are scrolled out of the
viewport.

closes COPS-6624
  • Loading branch information
pierrebeitz committed Oct 30, 2020
1 parent 87806d4 commit 8bf67ed
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/styles/hacks.less
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// COPS-6624
// popper.js sometimes seems to think that our reference elements are outside of the viewport and marks them with this attribute.
// ui-kit then chooses to set `visibility: hidden; pointer-events: none;`, which effectively hides the poppers for some OSX users.
// this is a quickfix that we could try removing once we removed FullScreenModal from the code base.
body [data-popper-reference-hidden] {
visibility: visible !important;
pointer-events: auto !important;
}
3 changes: 3 additions & 0 deletions src/styles/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -536,3 +536,6 @@

@import 'views/services/variables.less';
@import 'views/services/styles.less';

// Stuff we'd love to get rid of
@import 'hacks.less';

0 comments on commit 8bf67ed

Please sign in to comment.