Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/11] Page template headers #1482

Merged
merged 10 commits into from Dec 5, 2016

Conversation

philipnrmn
Copy link
Contributor

@philipnrmn philipnrmn commented Dec 3, 2016

This PR introduces the new Page Header components. In order to keep noise low, I've stayed relatively faithful to the original interface of the components.

The page header is wrapped in a utility component and added to the Page namespace in order to allow subclasses of Page to override it.

The intent is to allow every view to control its header by defining itself as a page, eg

<Page>
  <Page.Header breadcrumbs={...} />
  {usual page content here}
</Page>

@d2iq-mergebot
Copy link

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot integrate-it
@mesosphere-mergebot ship-it
@mesosphere-mergebot test-it

@orlandohohmeier
Copy link
Contributor

orlandohohmeier commented Dec 3, 2016

Let's create issues for the open todos and get this one merge so that it no longer blocks #1483

@philipnrmn philipnrmn force-pushed the philipnrmn/dcos-11695/templateable-header branch 2 times, most recently from 450b909 to 8258c67 Compare December 5, 2016 01:35
@philipnrmn philipnrmn force-pushed the philipnrmn/dcos-11695/templateable-header branch from 8258c67 to ef706e4 Compare December 5, 2016 02:29
@philipnrmn philipnrmn force-pushed the philipnrmn/dcos-11695/templateable-header branch from f4de653 to a145bf9 Compare December 5, 2016 05:01
@philipnrmn philipnrmn changed the title [WIP] Page template headers [1/11] Page template headers Dec 5, 2016
@orlandohohmeier orlandohohmeier changed the base branch from master to feature/page-header December 5, 2016 12:53
@orlandohohmeier
Copy link
Contributor

✨ Awesome


let innerLinkSpan = <span className="menu-tabbed-item-label-text">{tab.label}</span>;
let link = tab.callback == null
? <Link className={linkClasses} to={tab.routePath}>{innerLinkSpan}</Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with ternary until we have decided to start using it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@mlunoe mlunoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's ship

@mlunoe mlunoe added the reviewer label Dec 5, 2016
@mlunoe mlunoe merged commit d54d642 into feature/page-header Dec 5, 2016
@mlunoe mlunoe deleted the philipnrmn/dcos-11695/templateable-header branch December 5, 2016 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants