New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/11] Page template headers #1482
[1/11] Page template headers #1482
Conversation
This repo has @mesosphere-mergebot integration. You can interact with the following commands.
|
02e01fb
to
f8187d4
Compare
|
450b909
to
8258c67
Compare
8258c67
to
ef706e4
Compare
f4de653
to
a145bf9
Compare
✨ Awesome |
|
||
let innerLinkSpan = <span className="menu-tabbed-item-label-text">{tab.label}</span>; | ||
let link = tab.callback == null | ||
? <Link className={linkClasses} to={tab.routePath}>{innerLinkSpan}</Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait with ternary until we have decided to start using it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's ship
This PR introduces the new Page Header components. In order to keep noise low, I've stayed relatively faithful to the original interface of the components.
The page header is wrapped in a utility component and added to the Page namespace in order to allow subclasses of Page to override it.
The intent is to allow every view to control its header by defining itself as a page, eg