Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCOS-14694: split healthchecks #2028

Merged

Conversation

Poltergeist
Copy link
Contributor

@Poltergeist Poltergeist commented Mar 22, 2017

Checklist

  • Did you add a JIRA issue in a commit message or as part of the branch name?
  • Did you add new unit tests?
  • Did you add new integration tests?
  • If this is a regression, did you write a test to catch this in the future?

Part of #2076

@d2iq-mergebot
Copy link

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot ship-it
@mesosphere-mergebot integrate
@mesosphere-mergebot test

@Poltergeist Poltergeist changed the base branch from master to ph/refactor/reducers March 22, 2017 17:50
@nLight
Copy link
Contributor

nLight commented Mar 22, 2017

Why do we want to extract that piece? :)

@nLight
Copy link
Contributor

nLight commented Mar 22, 2017

Looks and works good though

@orlandohohmeier
Copy link
Contributor

@nLight extracting the form reducers is the first towards making the reducers service type agnostic.

@Poltergeist Poltergeist force-pushed the ph/refactor/DCOS-14694-Split-healthchecks branch from 9c99cde to defd30d Compare March 28, 2017 10:56
@Poltergeist
Copy link
Contributor Author

mesosphere-ci retest this please

@nLight
Copy link
Contributor

nLight commented Apr 5, 2017

flicts!

@Poltergeist
Copy link
Contributor Author

run integration tests

@Poltergeist Poltergeist force-pushed the ph/refactor/DCOS-14694-Split-healthchecks branch from 5ca6019 to 92c9687 Compare April 6, 2017 13:58
@jfurrow
Copy link
Contributor

jfurrow commented Apr 10, 2017

Looks & works well!

@jfurrow jfurrow merged commit 2222ca4 into ph/refactor/reducers Apr 10, 2017
@jfurrow jfurrow deleted the ph/refactor/DCOS-14694-Split-healthchecks branch April 10, 2017 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants