New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCOS-14694: split healthchecks #2028
Merged
jfurrow
merged 1 commit into
ph/refactor/reducers
from
ph/refactor/DCOS-14694-Split-healthchecks
Apr 10, 2017
Merged
DCOS-14694: split healthchecks #2028
jfurrow
merged 1 commit into
ph/refactor/reducers
from
ph/refactor/DCOS-14694-Split-healthchecks
Apr 10, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo has @mesosphere-mergebot integration. You can interact with the following commands.
|
Poltergeist
force-pushed
the
ph/refactor/reducers
branch
from
March 22, 2017 17:51
82d5113
to
4e2b867
Compare
Why do we want to extract that piece? :) |
Looks and works good though |
@nLight extracting the form reducers is the first towards making the reducers service type agnostic. |
Poltergeist
force-pushed
the
ph/refactor/DCOS-14694-Split-healthchecks
branch
from
March 28, 2017 10:56
9c99cde
to
defd30d
Compare
mesosphere-ci retest this please |
flicts! |
run integration tests |
Poltergeist
force-pushed
the
ph/refactor/reducers
branch
from
April 6, 2017 13:45
5e72e50
to
9a59d46
Compare
Poltergeist
force-pushed
the
ph/refactor/DCOS-14694-Split-healthchecks
branch
from
April 6, 2017 13:58
5ca6019
to
92c9687
Compare
Looks & works well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Part of #2076