New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCOS-57015: Jobs - Enable/Disable Schedule sets concurrencyPolicy to ALLOW #4022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes work as expected and code looks good to me. Tagging @natmegs for review because she's spent a lot of time with the Jobs form
@@ -10,7 +10,8 @@ import { | |||
export const JobDataPlaceholders = { | |||
maxLaunchDelay: 3600, | |||
timezone: "UTC", | |||
startingDeadlineSeconds: 900 | |||
startingDeadlineSeconds: 900, | |||
concurrencyPolicy: "FORBID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this or make the placeholder "ALLOW", as that is what the metronome API defaults to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I made it "forbid" since the checkbox is unchecked by default.
Persist concurency policy when enabling and disabling schedule using the dropdown. Closes DCOS-57015
2159103
bd256f9
to
2159103
Compare
🎉 This PR is included in version 2.142.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Persist concurency policy when enabling and
disabling schedule using the dropdown.
Closes https://jira.mesosphere.com/browse/DCOS-57015
Testing
Example JSON:
Trade-offs
None.
Dependencies
None.
Screenshots
Before
After