New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump marathon to v1.4.0-RC8 #1231
Conversation
380c8de
to
cafe34a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@jdef can we get a corresponding enterprise PR bump as well? |
@lingmann there is one. I referenced this PR there |
I see it now, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified SHA1 of tarball. Assuming rc8 is better than rc7, and only includes the 2 fixes listed in the PR description.
The JIRAs mentioned were the only ones linked to the GH tickets. Possible
that there are JIRAs for other changes mentioned in the change log.
…On Feb 13, 2017 7:40 PM, "Adam" ***@***.***> wrote:
***@***.**** approved this pull request.
Verified SHA1 of tarball. Assuming rc8 is better than rc7, and only
includes the 2 fixes listed in the PR description.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1231 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLAHwvdWXhnr8dWRQ9r47k6spXOglks5rcPf6gaJpZM4L9-SH>
.
|
High Level Description
Related Issues
network-scope
flag for mesocontainerizerChecklist for all PR's
Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath
packages
), then in addition to the above please also include:PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:
It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.