Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump marathon to v1.4.0-RC8 #1231

Merged
merged 1 commit into from Feb 15, 2017
Merged

Conversation

jdef
Copy link

@jdef jdef commented Feb 10, 2017

High Level Description

  • bump Marathon from 1.4.0-RC7 to 1.4.0-RC8

Related Issues

  • MARATHON-1378 pod tasks are missing DiscoveryInfo; broken for minuteman
  • MARATHON-1383 Marathon is not setting network-scope flag for mesocontainerizer

Checklist for all PR's

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:


PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE

Instructions and Review Process

What is the review process and when will my changes land?

All PRs require 2 approvals using github's pull request reviews.

Reviewers should be:

  • Developers who understand the code being modified.
  • Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

Copy link
Contributor

@spahl spahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lingmann
Copy link
Contributor

@jdef can we get a corresponding enterprise PR bump as well?

@spahl
Copy link
Contributor

spahl commented Feb 13, 2017

@lingmann there is one. I referenced this PR there

@lingmann
Copy link
Contributor

I see it now, thanks

branden added a commit to mesosphere/dcos that referenced this pull request Feb 14, 2017
branden added a commit to mesosphere/dcos that referenced this pull request Feb 14, 2017
@branden branden mentioned this pull request Feb 14, 2017
6 tasks
Copy link
Contributor

@adam-mesos adam-mesos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified SHA1 of tarball. Assuming rc8 is better than rc7, and only includes the 2 fixes listed in the PR description.

@jdef
Copy link
Author

jdef commented Feb 14, 2017 via email

branden added a commit to mesosphere/dcos that referenced this pull request Feb 14, 2017
@lingmann lingmann merged commit cafe34a into dcos:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants