Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Mesos to latest 1.2.x (f8706e5). #2104

Merged

Conversation

karya0
Copy link
Contributor

@karya0 karya0 commented Nov 15, 2017

High-level description

Bumped Mesos to latest 1.2.x (f8706e5).

Corresponding DC/OS tickets (obligatory)

Related tickets (optional)

Checklist for all PRs

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

  • Change log from the last version integrated (this should be a link to commits for easy verification and review): Mesos Changelog
  • Test Results:
  • Code Coverage

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE

Instructions and review process

What is the review process and when will my changes land?

All PRs require 2 approvals using GitHub's pull request reviews.

Reviewers should be:

  • Developers who understand the code being modified.
  • Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@d2iq-mergebot
Copy link
Collaborator

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot bump-ee  
@mesosphere-mergebot pr-status-checks  
@mesosphere-mergebot merge-it  
@mesosphere-mergebot ship_it_label_status_check  
@mesosphere-mergebot label [Ship It |Work In Progress |Request For Comment |Ready For Review |Holding] 
  • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.

@karya0
Copy link
Contributor Author

karya0 commented Nov 15, 2017

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/1720

@karya0
Copy link
Contributor Author

karya0 commented Nov 21, 2017

The teamcity/dcos/test/aws/cloudformation/simple failure due to ProviderError: An error occurred (ValidationError) when calling the CreateStack operation: Parameters: [DefaultInstanceType] do not exist in the template seems to be a known problem and not caused by this PR.

@karya0
Copy link
Contributor Author

karya0 commented Nov 21, 2017

@mesosphere-mergebot label [Ready For Review]

@karya0
Copy link
Contributor Author

karya0 commented Nov 21, 2017

@vinodkone @adam-mesos: When you get a chance, can you fellas review this PR?

Copy link
Contributor

@greggomann greggomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Mesos bump LGTM.

@jgehrcke
Copy link
Contributor

We need to have a DC/OS JIRA ticket that tracks this change, and it must be linked in this pull request.

@karya0
Copy link
Contributor Author

karya0 commented Nov 27, 2017

@orsenthil orsenthil mentioned this pull request Nov 27, 2017
Copy link
Contributor

@adam-mesos adam-mesos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Identical to Mesos 1.2.3-rc1 except for the CHANGELOG update. Good enough for me!

@d2iq-mergebot d2iq-mergebot merged commit 9aba31c into dcos:1.9 Nov 28, 2017
@jgehrcke jgehrcke added this to the 1.9.6 milestone Nov 28, 2017
@karya0 karya0 deleted the kapil/dcos-1.9-mesos-1.2.x-f8706e5 branch May 21, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants