New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Bump Mesos to nightly master a1c6a7a #2808
[master] Bump Mesos to nightly master a1c6a7a #2808
Conversation
@mesosphere-mergebot bump-ee |
This repo has @mesosphere-mergebot integration. You can interact with the following commands.
|
Enterprise Bump PR: mesosphere/dcos-enterprise/pull/2668 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that https://github.com/mesosphere/mesos/commits/dcos-mesos-master-nightly-a1c6a7a points to the most recent master and has all necessary cherry-picks.
"single_source": { | ||
"kind": "git", | ||
"git": "https://github.com/dcos/dcos-mesos-modules.git", | ||
"ref": "b0ecfa4466f0b377cc419b583f90c8c926aebc12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack that this is the sha for the current head of the mesos modules repo.
"kind": "git", | ||
"git": "https://github.com/mesosphere/mesos", | ||
"ref": "97de6eea9ad70f700082f70cd8d2584e199186df", | ||
"ref_origin" : "dcos-mesos-master-e91ce42ed" | ||
"ref": "7659c405f51c1771fd341c9fad34085982774014", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack that this is the tip of the dcos-mesos-master-nightly-a1c6a7a
branch.
How can I verify that this is the desired branch though?
Would an encoding of the date after the word "nightly" make more sense than a random sha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SHA helps us identify the appropriate apache/mesos commit on top of which we applied the cherry-picks. We can certainly add some date as well but the SHA should still be left in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so the a1c6a7a
in dcos-mesos-master-nightly-a1c6a7a
is the SHA on upstream master on top of which all of the commits below are being cherry-picked. No need for a date then, that's clear enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
"description": "Revert \"Fixed the broken metrics information of master in WebUI.\"" | ||
}, | ||
{ | ||
"ref": "a9f5ddb8614ef057537994f389eb7e19f0c85652", | ||
"ref": "7659c405f51c1771fd341c9fad34085982774014", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack that this is the right commit at the tip of the branch.
}, | ||
{ | ||
"ref": "c9c5537b229fa55b5d5034b5fc40ae450fbbd08b", | ||
"ref": "9796bf3d889397aa6ee707c937af4e8c757c9f2a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack that this is the correct commit 2nd from the tip.
}, | ||
{ | ||
"ref": "d523dba4ca02ad15c0ce2fb9a93a7a1d7ec0eedf", | ||
"description": "Mesos UI: Change paths, pailer, and logs to work with a reverse proxy" | ||
"ref": "b6d7b1f3ca61a536132b3e973c32dd695e181005", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack that this is the correct commit 3rd from the tip.
@@ -3,19 +3,19 @@ | |||
"git": "https://github.com/mesosphere/mesos", | |||
"patches": [ | |||
{ | |||
"ref": "23dda3f685fbc552646ca5e4a560b1256640eda4", | |||
"description": "Set LIBPROCESS_IP into docker container" | |||
"ref": "0f762c15455900083f7a3f72c6cdc60a418ec12f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack that this is the correct commit 4th from the tip.
"ref": "683d3c137ed66d6e9a7e5da622f62a7ce962d4d1", | ||
"ref_origin": "master" | ||
} | ||
"requires": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just white space changes here?
@@ -1,24 +1,29 @@ | |||
{ | |||
"requires": ["openssl", "libevent", "curl", "boost-libs"], | |||
"single_source" : { | |||
"requires": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just white space changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whitespace changes, here and below, are fixing the previous ad-hoc formatting.
"vm.max_map_count": 262144, | ||
"vm.swappiness": 1 | ||
} | ||
"dcos-mesos-slave": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just white space changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified mesos commits.
@mesosphere-mergebot label Ready For Review |
👋 This PR has been inactive for 3 days. Please review the status checks to see what needs to be done to move it forward or change the label to Work in Progress. Thank you! |
This PR has been reverted and hence has not been merged! |
High-level description
This is a routine bump to the latest master branch of Mesos.
It also changes 2 DC/OS specific cherry-picks.
Following the recent change in UCR code an update of the cherry-pick related to the GPU isolator failure is required.
a9f5ddb8614ef057537994f389eb7e19f0c85652
->7659c405f51c1771fd341c9fad34085982774014
Following an update of the Web controllers in Apache Mesos, an update of the cherry-pick affecting those controllers is also required.
d523dba4ca02ad15c0ce2fb9a93a7a1d7ec0eedf
->b6d7b1f3ca61a536132b3e973c32dd695e181005
Related JIRA Issues
Checklist for all PRs
Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath
packages
), then in addition to the above please also include:mesosphere/mesos diff
dcos/dcos-mesos-modules diff
mesosphere/dcos-ee-mesos-modules diff