New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "packages/cockroach: improve iam-database-restore script" #4446
Conversation
This reverts commit 0bcab68.
This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.
|
@mesosphere-mergebot bump-ee |
Enterprise Bump PR: mesosphere/dcos-enterprise/pull/4582 |
@mesosphere-mergebot label Ready For Review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work here - I'm glad you asked the cockroachdb folks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Martin
This reverts commit 0bcab68.
High-level description
The #4251 changed
iam-database-restore
script on a false assumption that database renames could be handled transactionally.After consulting with CockroachDB https://forum.cockroachlabs.com/t/renaming-database-in-a-transaction/2397 I've confirmed that this is not the case and we need to revert to a previous restore script version.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
Checklist for all PRs
CHANGES.md
or explain why this is not a user-facing change: this fixes a problem of unreleased version