Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "packages/cockroach: improve iam-database-restore script" #4446

Merged
merged 1 commit into from Feb 13, 2019

Conversation

mhrabovcin
Copy link
Contributor

@mhrabovcin mhrabovcin commented Feb 7, 2019

This reverts commit 0bcab68.

High-level description

The #4251 changed iam-database-restore script on a false assumption that database renames could be handled transactionally.

After consulting with CockroachDB https://forum.cockroachlabs.com/t/renaming-database-in-a-transaction/2397 I've confirmed that this is not the case and we need to revert to a previous restore script version.

Corresponding DC/OS tickets (obligatory)

These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

  • DCOS-48182 cockroach: confirm that database renames are transactional

Checklist for all PRs

  • Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: this fixes a problem of unreleased version
  • Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
  • Read the DC/OS contributing guidelines
  • Followed relevant code rules Rules for Packages and Systemd

@d2iq-mergebot
Copy link
Collaborator

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot label [Ready For Review|Holding|Ship It|Work In Progress|Request For Comment] 
@mesosphere-mergebot merge-it  
@mesosphere-mergebot sync  
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot override-status pr-status-check jira-url 
  • PR creators can apply one of [Ready For Review|Work In Progress]. Owners can apply any label.

@d2iq-mergebot
Copy link
Collaborator

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/4582

@mhrabovcin
Copy link
Contributor Author

@mesosphere-mergebot label Ready For Review

@mhrabovcin
Copy link
Contributor Author

@gpaul @jongiddy please have a look.

Copy link
Contributor

@gpaul gpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work here - I'm glad you asked the cockroachdb folks.

Copy link
Contributor

@jongiddy jongiddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin

d2iq-mergebot added a commit to mesosphere/dcos that referenced this pull request Feb 12, 2019
d2iq-mergebot added a commit to mesosphere/dcos that referenced this pull request Feb 12, 2019
d2iq-mergebot added a commit to mesosphere/dcos that referenced this pull request Feb 12, 2019
@d2iq-mergebot d2iq-mergebot merged commit d92d043 into dcos:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants