-
Notifications
You must be signed in to change notification settings - Fork 56
Symmetric extrude with respect to the workplane #146
Conversation
Added additional parameter (both=Flase by default) to the extrude method which allows to symmetrically extrude with respect to he current workplane
Not sure if you accept PRs, but would be nice to also have symmetric extrude |
Thanks @adam-urbanczyk we do accept PRs. Would you be able to add a test case for symmetric extrusion, please? |
Added a test case for symmetric extrusion operation.
Does it look better now? |
Yes, thanks. The only other thing that I would suggest would be to add an explicit 0 after the decimal places in the floats for consistency. Other than that it's ready to merge. |
By consistency I mean that we've used trailing 0s throughout the codebase, unless I've overlooked something. |
This looks ok to me |
@dcowden I'm fine with that. I suspect that the Coveralls issue is separate. I'd say go ahead and merge. |
@adam-urbanczyk thanks for the contribution! Merged. |
@adam-urbanczyk Agreed. We appreciate the help. |
Added additional parameter (both=Flase by default) to the extrude method
which allows to symmetrically extrude with respect to he current
workplane