Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Symmetric extrude with respect to the workplane #146

Merged
merged 2 commits into from
May 23, 2016

Conversation

adam-urbanczyk
Copy link
Contributor

Added additional parameter (both=Flase by default) to the extrude method
which allows to symmetrically extrude with respect to he current
workplane

Added additional parameter (both=Flase by default) to the extrude method
which allows to symmetrically extrude with respect to he current
workplane
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.9%) to 74.595% when pulling 32160d1 on adam-urbanczyk:master into bcea03d on dcowden:master.

@adam-urbanczyk
Copy link
Contributor Author

Not sure if you accept PRs, but would be nice to also have symmetric extrude

@jmwright
Copy link
Collaborator

Thanks @adam-urbanczyk we do accept PRs. Would you be able to add a test case for symmetric extrusion, please?

Added a test case for symmetric extrusion operation.
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.8%) to 74.696% when pulling 58683d0 on adam-urbanczyk:master into bcea03d on dcowden:master.

@adam-urbanczyk
Copy link
Contributor Author

Does it look better now?

@jmwright
Copy link
Collaborator

Yes, thanks. The only other thing that I would suggest would be to add an explicit 0 after the decimal places in the floats for consistency. Other than that it's ready to merge.

@jmwright
Copy link
Collaborator

By consistency I mean that we've used trailing 0s throughout the codebase, unless I've overlooked something.

@dcowden
Copy link
Owner

dcowden commented May 23, 2016

This looks ok to me
@jmwright are you comfortable that the coveage issue is unrelated to the changes in this PR? if so I'll merge it.

@jmwright
Copy link
Collaborator

@dcowden I'm fine with that. I suspect that the Coveralls issue is separate. I'd say go ahead and merge.

@dcowden dcowden merged commit b41d52f into dcowden:master May 23, 2016
@dcowden
Copy link
Owner

dcowden commented May 23, 2016

@adam-urbanczyk thanks for the contribution! Merged.

@jmwright
Copy link
Collaborator

@adam-urbanczyk Agreed. We appreciate the help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants