This repository has been archived by the owner on Feb 9, 2021. It is now read-only.
Make pyparsing an actual cadquery requirement #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @Peque. |
|
Thank you for this contribution!
…On Feb 11, 2017 10:47 AM, "Miguel Sánchez de León Peque" < ***@***.***> wrote:
Currently, installing cadquery with pip does not results in pyparsing
been installed. However, cadquery fails to run without it, so maybe it
should be set as an install requirement.
------------------------------
You can view, comment on, or merge this pull request online at:
#176
Commit Summary
- Make pyparsing an actual cadquery requirement
File Changes
- *M* requirements.txt
<https://github.com/dcowden/cadquery/pull/176/files#diff-0> (2)
- *M* setup.py
<https://github.com/dcowden/cadquery/pull/176/files#diff-1> (3)
Patch Links:
- https://github.com/dcowden/cadquery/pull/176.patch
- https://github.com/dcowden/cadquery/pull/176.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#176>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPOA6IaB3hlSaYnIEE7yCVCguOCNB5dks5rbdgmgaJpZM4L-NTd>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, installing
cadquerywithpipdoes not results inpyparsingbeing installed. However,cadqueryfails to run without it, so maybe it should be set as an install requirement.