Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Implement CI on Windows #248

Merged
merged 10 commits into from
Mar 27, 2018
Merged

Implement CI on Windows #248

merged 10 commits into from
Mar 27, 2018

Conversation

adam-urbanczyk
Copy link
Contributor

Seems to be working fine. Only thing left is to setup CI on this repo

@dcowden
Copy link
Owner

dcowden commented Mar 26, 2018

@adam-urbanczyk is that something we'd prefer done with my account?

@coveralls
Copy link

coveralls commented Mar 26, 2018

Coverage Status

Coverage decreased (-0.2%) to 92.134% when pulling 45b6e1a on adam-urbanczyk:master into 146ae81 on dcowden:master.

@adam-urbanczyk
Copy link
Contributor Author

@dcowden I am trying something via the account of @jmwright on appveyor. Let's see how it goes

@dcowden
Copy link
Owner

dcowden commented Mar 26, 2018

@adam-urbanczyk it looks like since Github doesnt have an appveyor service, we probably need to register a webhook to trigger builds?

@adam-urbanczyk
Copy link
Contributor Author

@dcowden you are right, can you register this:

https://ci.appveyor.com/api/github/webhook?id=74am3oainm4mk78r

@dcowden
Copy link
Owner

dcowden commented Mar 26, 2018

Will do!

@dcowden
Copy link
Owner

dcowden commented Mar 26, 2018

done-- added for both pull request and push.

@AppVeyorBot
Copy link

@adam-urbanczyk
Copy link
Contributor Author

adam-urbanczyk commented Mar 27, 2018

Thanks, it works! The coverage decrease is due to Windows specific code (cf. #247).

@dcowden
Copy link
Owner

dcowden commented Mar 27, 2018

Merging this, thanks for setting it up!

@dcowden dcowden merged commit 66054b0 into dcowden:master Mar 27, 2018
@adam-urbanczyk
Copy link
Contributor Author

For future reference this PR was solving #246

This was referenced Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants