Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Dont install freecad-doc in the Travis build #256

Merged
merged 1 commit into from Apr 30, 2018
Merged

Dont install freecad-doc in the Travis build #256

merged 1 commit into from Apr 30, 2018

Conversation

gntech
Copy link
Contributor

@gntech gntech commented Apr 26, 2018

The freecad-doc package download weighs in at about 150 MB and adds several
minutes to the travis build time for no purpose (not that I know of that is 😄 ).

@AppVeyorBot
Copy link

Build cadquery 1.0.27 failed (commit a190cc3009 by @gntech)

@coveralls
Copy link

coveralls commented Apr 26, 2018

Coverage Status

Coverage remained the same at 92.252% when pulling 1146a59 on gntech:speed-up-travis into 491ec9f on dcowden:master.

@AppVeyorBot
Copy link

Build cadquery 1.0.28 failed (commit a190cc3009 by @gntech)

@jmwright
Copy link
Collaborator

This build seems to be failing in both Travis and AppVeyor, but both seem due to the Anaconda setup. @adam-urbanczyk Do you have any thoughts on what might be happening? In AppVeyor the FreeCAD package seems to be inaccessible. In Travis it says that the freecad_cq3 environment is not available.

@adam-urbanczyk
Copy link
Contributor

adam-urbanczyk commented Apr 27, 2018 via email

@AppVeyorBot
Copy link

Build cadquery 1.0.36 completed (commit 985a383d38 by @gntech)

@jmwright
Copy link
Collaborator

@gntech Could you do a rebase on this like you did for #257 so we can merge it?

@dcowden You didn't have freecad-doc included because you needed it for the Sphinx docs generation scripts did you?

@dcowden
Copy link
Owner

dcowden commented Apr 29, 2018

@jmwright I don't think so, but it's been a while so I don't really trust my memory

The freecad-doc package download weighs in at about 150 MB and adds several
minutes to the travis build time for no purpose.
@gntech
Copy link
Contributor Author

gntech commented Apr 30, 2018

@jmwright I have rebased this pull request now

@AppVeyorBot
Copy link

Build cadquery 1.0.37 completed (commit 364ff187f2 by @gntech)

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          10       10           
  Lines        2207     2207           
=======================================
  Hits         2048     2048           
  Misses        159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491ec9f...1146a59. Read the comment docs.

@jmwright
Copy link
Collaborator

@gntech Thanks!

@jmwright jmwright merged commit f261411 into dcowden:master Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants