Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Switched to Miniconda and added cqparts to Dockerfile. #277

Merged
merged 1 commit into from Jun 2, 2018
Merged

Conversation

jmwright
Copy link
Collaborator

@jmwright jmwright commented Jun 1, 2018

@dcowden This does technically work, but treat it as a WIP until I get a more real-world test done. I'm making these changes to support the STEMN work, and so a mock setup of doing a conversion will probably be the test. I'm guessing there will be issues due to the CQGI show_object and cqparts display differences though.

This change adds cqparts and it's sub-libraries to the Dockerfile since cqparts is becoming such a crucial part of the CadQuery ecosystem. I also switched to Miniconda, which dropped the image size from 4.09GB to 1.74GB.

@fragmuffin @adam-urbanczyk This might be something you will at least want to be aware of too.

@AppVeyorBot
Copy link

Build cadquery 1.0.50 completed (commit 56f345c2a1 by @jmwright)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.252% when pulling 4a9fb59 on docker into 0e1002e on master.

@dcowden
Copy link
Owner

dcowden commented Jun 1, 2018

@jmwright awesome stuff!

@jmwright
Copy link
Collaborator Author

jmwright commented Jun 2, 2018

Ok, this does work with cqparts scripts, but the catch is that the user has to call show_object(body.local_obj) for now. That's not a problem for me, but hopefully when CQGI is modified per recent discussions we can converge the display methods.

If there are no objections, @dcowden or someone else can merge. Otherwise I'll probably wait until later in the day tomorrow (UTC-5) to give time for comment and then merge it myself.

@dcowden
Copy link
Owner

dcowden commented Jun 2, 2018

Looks good to me.

@dcowden dcowden merged commit 318e11b into master Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants