New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django >= 1.7 compatibility for requires_system_checks #99
Conversation
Backwards compatible with Django < 1.7.
PS. An alternative is to just delete line 70 (at the expense of explicitness) because the superclass sets the appropriate attribute to False anyway. |
Looks like this is tripping me up, too. |
Just ran into this too, be nice if it can be pulled in. |
Same here. @dcramer any chance we can get this merged? |
+1. Gotta use personal fork for this, please merge this :) |
+1 waiting for merge |
+1 please merge |
Django >= 1.7 compatibility for requires_system_checks
Thanks @dcramer 🎆 |
👍 |
Thanks @dcramer. When you get a chance could you make a 0.8.1 release to PyPI please, so we can get it from there in a pip install? |
Merged fix forces validation for Django 1.6 and below, is that on purpose? |
+1 for
|
Shouldn't this be changing |
Hi @dcramer,
Devserver will fail to start up on Django 1.7 with the error:
The django-devserver runserver management command inherits from the django core runserver management command which set
requires_system_checks = False
. The django-devserver runserver management command then setsrequires_model_validation = False
.This pull request ensures only the appropriate attribute is set to False, so is backwards compatible with Django < 1.7.
The implementation is only suggested. If you have another way you'd prefer to do it that's fine, this was just a convenient way to illustrate the issue.