Fixing small bug with CharFields.max_length < 15

dcramer · Jun 9, 2010 · fe85e28 · fe85e28
1 parent 8a4387d
commit fe85e28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/autofixture/base.py b/src/autofixture/base.py
@@ -307,6 +307,7 @@ def get_generator(self, field):
                 return generators.LoremSentenceGenerator(
                     common=False,
                     max_length=field.max_length)
+            else:
                 generator = generators.StringGenerator
             return generator(max_length=field.max_length)
         if isinstance(field, fields.DecimalField):

diff --git a/src/autofixture/tests.py b/src/autofixture/tests.py
@@ -47,6 +47,7 @@ class NullableFKModel(models.Model):
 
 class BasicModel(models.Model):
     chars = models.CharField(max_length=50)
+    shortchars = models.CharField(max_length=2)
     blankchars = models.CharField(max_length=100, blank=True)
     nullchars = models.CharField(max_length=100, blank=True, null=True)
     slugfield = models.SlugField()
@@ -138,6 +139,8 @@ def test_constraints(self):
         for obj in filler.create(100):
             self.assertTrue(len(obj.chars) > 0)
             self.assertEqual(type(obj.chars), unicode)
+            self.assertTrue(len(obj.shortchars) <= 2)
+            self.assertEqual(type(obj.shortchars), unicode)
             self.assertTrue(type(obj.blankchars), unicode)
             self.assertEqualOr(type(obj.nullchars), unicode, None)
             self.assertEqual(type(obj.slugfield), unicode)