Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device entities and update version #8

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

dronenb
Copy link
Contributor

@dronenb dronenb commented Jun 15, 2023

No description provided.

@dronenb
Copy link
Contributor Author

dronenb commented Jun 15, 2023

Fix #6

@tfasz
Copy link

tfasz commented Jul 19, 2023

Interested in trying this out - any update on if this will be merged?

@briancmpbll
Copy link
Contributor

I pulled these changes into my HASS instance and I now get devices for each group and scene on the luxor. They don't seem to update consistently when the groups are turned on outside of home assistant though.

@dcramer
Copy link
Owner

dcramer commented Aug 4, 2023

Thanks for the ping! Not sure why I lost this. Do we know if there are differing versions of th Luxor controllers and/or firmware that might be related at all? We're doing some construction so I can't actually test anything, but I have also noticed extremely flakey behavior (on top of some changes to HASS tha thave broken the integration). I will say the flakey behavior has always somewhat been present, and I think is just a property of how the Luxor controllers work.

@dcramer
Copy link
Owner

dcramer commented Aug 4, 2023

Also, I'm going to go ahead and merge this given @briancmpbll has at least verified its not completely broken, but if folks report breakage we can consider some kind of version branding and support both paths.

@dcramer dcramer merged commit 52d87a6 into dcramer:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants