Debug allocator should always abort #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We provide a "debug" allocator, which verifies that the sizes that you provide to the allocation functions matches the sizes that you provide to the deallocation functions. Before, we used the builtin `assert` macro to perform this check. However, that means that if we compile libcork in `Release` mode (in which asserts are left out), we never actually perform the check! We now use an explicit check, and call `abort` ourselves if the check fails — our assumption being that if you ask for the debug allocator, you want at least this particular bit of debug behavior even if the rest of the library was compiled in `Release` mode.
dcreager
force-pushed
the
feature/debug-assert
branch
from
bbf580b
to
939ba35
Compare
dcreager
pushed a commit
that referenced
this pull request
Jun 29, 2015
Debug allocator should always abort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide a "debug" allocator, which verifies that the sizes that you provide to the allocation functions matches the sizes that you provide to the deallocation functions. Before, we used the builtin
assertmacro to perform this check. However, that means that if we compile libcork inReleasemode (in which asserts are left out), we never actually perform the check! We now use an explicit check, and callabortourselves if the check fails — our assumption being that if you ask for the debug allocator, you want at least this particular bit of debug behavior even if the rest of the library was compiled inReleasemode.