Separate callback functions for cork_mempool #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cork_mempool type lets you provide `init_object` and `done_object` callbacks, which are called when an instance is first allocated and finally deallocated (i.e., exactly once per instance, regardless of how many times the instance is reused). This patch updates the API to have separate functions for setting each of those callbacks, instead of the single big function — this is more consistent with our current pattern, and is nicer for ABI compatibility reasons. The existing `set_callbacks` function still exists, but it's now deprecated and no longer mentioned in the documentation.
|
@johnzachary ready for review |
|
and/or @ermaxw |
|
+1 Looks like the way we should have done it all along 😄 |
dcreager
pushed a commit
that referenced
this pull request
Aug 26, 2015
Separate callback functions for cork_mempool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cork_mempool type lets you provide
init_objectanddone_objectcallbacks, which are called when an instance is first allocated and finally deallocated (i.e., exactly once per instance, regardless of how many times the instance is reused). This patch updates the API to have separate functions for setting each of those callbacks, instead of the single big function — this is more consistent with our current pattern, and is nicer for ABI compatibility reasons.The existing
set_callbacksfunction still exists, but it's now deprecated and no longer mentioned in the documentation.