Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click-through on frontline not working consistently #3295

Closed
Starfire13 opened this issue Dec 12, 2023 · 2 comments · Fixed by #3303
Closed

Click-through on frontline not working consistently #3295

Starfire13 opened this issue Dec 12, 2023 · 2 comments · Fixed by #3303
Labels
bug Something isn't working UX

Comments

@Starfire13
Copy link
Contributor

Starfire13 commented Dec 12, 2023

Affected versions

9.0.0, Development build

Build information

DCS Liberation 10.0.0
Build 5677
Git revision b014f2e

Description

Unlike the icons on the Liberation map (e.g. for control points, SAMs, resource sites, static targets, etc), the the orange line depicting the frontline is on a layer behind the flight paths. This makes is difficult to right-click on when you're trying to plan flights (typically CAS or TARCAP) to the frontline.

You end up getting this menu instead.

Screenshot 2023-12-13 073544

You can see in the picture below that the flight paths are below the icons on the map (see orange circle) rather than on top of them, unlike when they pass over the frontline.

Screenshot 2023-12-12 231902

When you first start Liberation, the campaign save that is auto-loaded on startup, will have a frontline that you can click-through to. However, if you load a different save file (it has to be a different one, not just reloading the one that auto-loaded), you will find that you can no longer click through to the frontline.

I don't think it really matters if the frontline is visually on the top layer. What is important is that you're able to click on it easily. At the moment, you can only get that functionality for the auto-save that gets loaded on Liberation startup.

Save game and other files (save game required, bugs without saves will be closed)

Bright Star #5677 Turn 1.liberation.zip

@Starfire13 Starfire13 added bug Something isn't working UX labels Dec 12, 2023
@DanAlbert
Copy link
Member

When you first start Liberation, the campaign save that is auto-loaded on startup, will have a frontline that you can click-through to. However, if you load a different save file (it has to be a different one, not just reloading the one that auto-loaded), you will find that you can no longer click through to the frontline.

Ah, yeah, that's the trick here. I can repro now.

@DanAlbert
Copy link
Member

The plot thickens: it only does that when the map is not run in dev mode... which would be the other reason I hadn't been able to repro this before.

DanAlbert added a commit to DanAlbert/dcs_liberation that referenced this issue Dec 19, 2023
This fixes the unusual case where the `interactive: false` property had
no effect, which would make it impossible to plan missions against UI
elements that were overflown by many flights (such as the front line).

As an added bonus, it looks a bit nicer.

This impacts the test in an odd way, but the cure for that is probably
rewriting the test to not use a mock now that we've figured out how to
do that.

Fixes dcs-liberation#3295.
DanAlbert added a commit that referenced this issue Dec 19, 2023
This fixes the unusual case where the `interactive: false` property had
no effect, which would make it impossible to plan missions against UI
elements that were overflown by many flights (such as the front line).

As an added bonus, it looks a bit nicer.

This impacts the test in an odd way, but the cure for that is probably
rewriting the test to not use a mock now that we've figured out how to
do that.

Fixes #3295.
Dragonius pushed a commit to Dragonius/dcs_liberation that referenced this issue Dec 23, 2023
This fixes the unusual case where the `interactive: false` property had
no effect, which would make it impossible to plan missions against UI
elements that were overflown by many flights (such as the front line).

As an added bonus, it looks a bit nicer.

This impacts the test in an odd way, but the cure for that is probably
rewriting the test to not use a mock now that we've figured out how to
do that.

Fixes dcs-liberation#3295.

(cherry picked from commit 1efce86)
Raffson pushed a commit to dcs-retribution/dcs-retribution that referenced this issue Mar 9, 2024
This fixes the unusual case where the `interactive: false` property had
no effect, which would make it impossible to plan missions against UI
elements that were overflown by many flights (such as the front line).

As an added bonus, it looks a bit nicer.

This impacts the test in an odd way, but the cure for that is probably
rewriting the test to not use a mock now that we've figured out how to
do that.

Fixes dcs-liberation/dcs_liberation#3295.
Dragonius pushed a commit to Dragonius/dcs_liberation that referenced this issue May 18, 2024
This fixes the unusual case where the `interactive: false` property had
no effect, which would make it impossible to plan missions against UI
elements that were overflown by many flights (such as the front line).

As an added bonus, it looks a bit nicer.

This impacts the test in an odd way, but the cure for that is probably
rewriting the test to not use a mock now that we've figured out how to
do that.

Fixes dcs-liberation#3295.

(cherry picked from commit 1efce86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants