-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncing lights #15
Comments
lets' discuss this one here, big topic |
I think it's prob best to playthrough and test all the lights to see where it isn't syncing up. First light should come on when clothes are donned, then proceed from there. There should only be 3 lights on in the dark, but now there is still the old 4 lights image. Sometimes the image doesn't sync with the icons or the textual description as seen in this one, at the beginning when no lights are on: Another time is here: |
you mean tasks 3/6 it should be 3 lights? |
The "task x/x" is something you coded so I don't want to comment on that. I think your task number is +1 of the lights, but you can check that part to see if it's synced. There's also a difference between "doing task 3" vs. "task 3 completed" since the completion of a puzzle task results in a light coming on. What I mean is that at any point there are 3 different ways that the number of lights currently on is indicated to the player. #1 command "look room" (jpeg image) (also automatically triggered when entering the room and when the room goes dark) The proper illustration should always match the state of the lights in the room. The progression is: no lights, 1 light, 2 lights, 3 lights/dark room, 4 lights. #2 command "look lights" (icon) (also automatically triggered when completing a puzzle task) You can see in the image here how this is not synced properly as only one light should be on. #3 text descriptions. Any text that describes the lights at any point should describe the proper state. Easiest way is to run through the game and test each of these by "look room" and "look lights" during each state to check. |
this lights thing is very confusing to track. I just need a clear list of what lights go with what and I can fix the story. enter room - no lights so basically at start of task1 = 0 light so basically task1: get dressed => 0 light => complete => 1 light seems to match: [Task 4/6] Three of the green lights are on, and a yellow light seeps through the window. |
if that's correct one of us could clean up the script |
task cuts
lights
|
has code
is this still wrong? easy enough to change it back to:
|
I did send a three lights dark already in response this issue this past
week. I’ll resend when I have the chance.
…On Sun, Nov 15, 2020 at 4:10 AM dc ***@***.***> wrote:
there's only 3 lights - normal
so ... i'm not sure if we're missing an image or how to deal with this
[image: image]
<https://user-images.githubusercontent.com/514002/99156010-53439f80-2672-11eb-98f7-34446e390b2c.png>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXLMT4K5QTQ4QOHIL77Z63SP3P4BANCNFSM4TQT3DCA>
.
|
ok found the image. |
think done now |
lights
right now
But it may get out of sync. it's a bit complicated/messy to track really (one thing i want to clean up with a proper hints/task system). did you notice where it goes out of sync?
or should it be
maybe thats why i'm confused
ach task3 is out of sync.
let me know what it should be here and i'll see if we can make a system to fix it.
ideally this would be part of a task list and we'd assign everything in a centralised place, but thats a lot more code.
its just a mess cleaning up scatted across the script.
also i did get confused originally on the counting.
I could make something like
progress: 3
a function that just renders the little progress bar. but then it would be more "fixed"task2
task3
yeah looks like this is out of sync
![image](https://user-images.githubusercontent.com/514002/98669921-ccf02c00-2306-11eb-81c7-f616e749aede.png)
task4
it looks like maybe lights were edited?
The text was updated successfully, but these errors were encountered: