Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for == operator on Termios #1

Merged
merged 2 commits into from Feb 9, 2015
Merged

Add support for == operator on Termios #1

merged 2 commits into from Feb 9, 2015

Conversation

conradkleinespel
Copy link
Contributor

Hi David,

Thanks a lot for publishing these bindings. These save me a lot of time! 馃槂

The current code does not compile with the latest rustc. In this PR, I make some minor changes so it compiles again. The changes include removing the #[allow(unstable)] lint, which has been removed. And I remove some extern crate libc lines which seem unnecessary.

Finally, I added support for using the == operator on Termios structs. This comes in handy for testing: for instance, if a library changes the TTY settings, I can test that the original TTY state is restored correctly with the == operator at the end of the test.

Please let me know if you have any questions 馃槈

Best regards,
Conrad

@conradkleinespel conradkleinespel changed the title catch up with language changes from rust-master Add support for == operator on Termios Feb 3, 2015
@conradkleinespel
Copy link
Contributor Author

Anything I can help you with, @dcuddeback ?

@dcuddeback
Copy link
Owner

@conradkleinespel Thanks for sending me these updates. I let my rustc get a little out of date, because I have it setup as a cross-compiler for my Raspberry Pi, which requires compiling Rust from source every time I update. Looks like it's time for me to update my compiler again. Sorry for not responding to this PR sooner. I didn't receive any notifications from Github when you first opened the PR, so I had no idea it was here until this morning.

dcuddeback added a commit that referenced this pull request Feb 9, 2015
Add support for `==` operator on Termios
@dcuddeback dcuddeback merged commit 8d7be11 into dcuddeback:master Feb 9, 2015
@conradkleinespel
Copy link
Contributor Author

@dcuddeback Thanks a lot for having had a look at this and merging it. I figured about the Github notifications, which is why I pinged you with your username. I'm just glad you took time out of your day to have a look at the contribution 馃憤

And thanks again for putting these bindings together 馃槂

Do you mind me asking what cool things you do with Rust on the Pi ?

@dcuddeback
Copy link
Owner

@conradkleinespel I'm glad that you found the bindings useful. I don't have much running on my Pi with Rust yet. I'm using these termios bindings to talk to an USB ZWave controller to control my bedside lamp. I currently have a C++ program running that slowly turns on my light at 6:30 each morning. I'm working on rewriting it in Rust. The C++ project is here: https://github.com/dcuddeback/zwave-sunrise

Btw, I pushed up your changes as version 0.0.2 to crates.io.

@conradkleinespel
Copy link
Contributor Author

@dcuddeback That's cool ! 馃憤 And thanks for the crates.io update :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants