Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40 use prop-types package #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Philipp91
Copy link

I confirmed that it actually stops the warning message (see #40) and the scrolling still works.

There are a bunch of other deprecation warnings, though.

Untested, still lacks reference in package.json.
hoping that this version actually exists
@santiagoGuti
Copy link

santiagoGuti commented Oct 17, 2017

Hello, We are using redux-infinite-scroll and lately we are trying to use react 16. Do you have an estimation when this pr is going to be merge and release? @Philipp91

@Philipp91
Copy link
Author

Me? No idea. I'm not the maintainer of this repository. It's been a while since I created this PR, but it seems like it's ready to merge?

@santiagoGuti
Copy link

@dcurletti can we merge this?

@nicolaidahl
Copy link

@dcurletti I don't mean to spam you, but it would be really nice if this could be merged. Any estimate as to when this could potentially happen? Thanks for a nice lib

@pathann
Copy link

pathann commented Nov 22, 2017

any word on the merging? - is a fork in order to keep this going / maintained?

@MichaelAP
Copy link

@pathann Sorry about this. The original maintainer is no longer with RealScout. I'm checking with him to see if he wants to take control of the repo, or most likely I'll be looking for another maintainer. I'll let you know in the next few days!

@pathann
Copy link

pathann commented Nov 22, 2017

@MichaelAP thanks. let me know.

@MichaelAP
Copy link

@pathann Hey, I've transferred ownership of the repo to it's creator, @dcurletti. Davide, hopefully you're able to merge some of these PR's soon? Thanks!

@dcurletti
Copy link
Owner

will get to merging/updating in the next few days.

@justinryder
Copy link

@dcurletti Any updates on the merge? This is the last dependency preventing me from upgrading to React 16.

@jacksonrayhamilton
Copy link

@dcurletti Please merge this.

@jacksonrayhamilton
Copy link

I published my fork with this update. It also switches to using react-transition-group.

yarn add @jacksonrayhamilton/redux-infinite-scroll@1.0.9-02bf627

@alexjfno1
Copy link

@dcurletti Can you merge this? Is this not being maintained anymore?

@Philipp91
Copy link
Author

fyi I'm using react-waypoint now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants