Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: the note of the react message is displayed with Callout #60

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

lautarovilas
Copy link
Contributor

Summary

The CustomCallout component was rewritten to migrate the text of "Note: this docummentation assumes..." to Callout

Task

Jira task

How did you test this change?

  • Manually
    image

@lautarovilas lautarovilas added the documentation Improvements or additions to documentation label Jul 29, 2023
@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 10:57pm

@tbor00
Copy link
Member

tbor00 commented Jul 31, 2023

I think we can create a custom component just for this alert, because you repeat all the props on the mdx's

<AlertReactKnowledge />

or something like that

@lautarovilas

@lautarovilas
Copy link
Contributor Author

Done, thanks

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tbor00 tbor00 merged commit 81685bd into main Aug 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants