Feat: add storybook links in the documentation of all components #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lautarovilas
requested review from
arielsrodriguez,
JuanDominguez1 and
Misael840
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tbor00
requested changes
Aug 2, 2023
| gap="2" | ||
| className="flex-row flex-wrap w-full" | ||
| > | ||
| <h1 {...titleProps}>{title}</h1> |
There was a problem hiding this comment.
we can use our component Text just here
There was a problem hiding this comment.
I can't use the Text component because it complains about typescript when passing the name attribute, and I can't find a way to fix it.
lautarovilas
force-pushed
the
feat/add-links-storybook
branch
from
1f456a8
to
b6b9e5e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tbor00
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A custom component was created to reuse for the title and the storybook link ( if the storybook documentation for that component exists ).
Task
Jira task
How did you test this change?