logging bug fix and change default behaviour

ddangelov · Oct 16, 2020 · abb2e7d · abb2e7d
1 parent 40ee79c
commit abb2e7d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/docs/conf.py b/docs/conf.py
@@ -29,7 +29,7 @@
 author = 'Dimo Angelov'
 
 # The full version, including alpha/beta/rc tags
-release = '1.0.14'
+release = '1.0.15'
 
 
 # -- General configuration ---------------------------------------------------

diff --git a/setup.py b/setup.py
@@ -6,7 +6,7 @@
 setuptools.setup(
     name="top2vec",
     packages=["top2vec"],
-    version="1.0.14",
+    version="1.0.15",
     author="Dimo Angelov",
     author_email="dimo.angelov@gmail.com",
     description="Top2Vec learns jointly embedded topic, document and word vectors.",

diff --git a/top2vec/Top2Vec.py b/top2vec/Top2Vec.py
@@ -147,9 +147,8 @@ class Top2Vec:
         Override the default tokenization method. If None then
         gensim.utils.simple_preprocess will be used.
     
-    verbose: bool (Optional, default False)
+    verbose: bool (Optional, default True)
         Whether to print status data during training.
-
     """
 
     def __init__(self,
@@ -163,12 +162,14 @@ def __init__(self,
                  keep_documents=True,
                  workers=None,
                  tokenizer=None,
-                 verbose=False):
+                 verbose=True):
 
         if verbose:
             logger.setLevel(logging.DEBUG)
+            self.verbose = True
         else:
             logger.setLevel(logging.WARNING)
+            self.verbose = False
 
         if tokenizer is not None:
             self._tokenizer = tokenizer
@@ -632,7 +633,8 @@ def _check_import_status(self):
 
     def _check_model_status(self):
         if self.embed is None:
-            logger.setLevel(logging.DEBUG)
+            if self.verbose is False:
+                logger.setLevel(logging.DEBUG)
 
             if self.embedding_model != "distiluse-base-multilingual-cased":
                 if self.embedding_model_path is None:
@@ -655,7 +657,9 @@ def _check_model_status(self):
                     module = self.embedding_model_path
                 model = SentenceTransformer(module)
                 self.embed = model.encode
-        logger.setLevel(logging.WARNING)
+
+        if self.verbose is False:
+            logger.setLevel(logging.WARNING)
 
     @staticmethod
     def _less_than_zero(num, var_name):
@@ -1082,7 +1086,7 @@ def get_topics(self, num_topics=None, reduced=False):
             
             Example:
             [[0.7132, 0.6473, 0.5700 ... 0.3455],  <Topic 0>
-            [0.7818', 0.7671, 0.7603 ... 0.6769]  <Topic 1>
+            [0.7818', 0.7671, 0.7603 ... 0.6769]   <Topic 1>
             ...]
 
         topic_nums: array of int, shape(num_topics)