Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gandi improvements #558

Merged
merged 2 commits into from
Nov 25, 2023
Merged

gandi improvements #558

merged 2 commits into from
Nov 25, 2023

Conversation

TinfoilSubmarine
Copy link
Contributor

No description provided.

@LenardHess
Copy link
Contributor

When using wantipv4/wantipv6, the provider implementation has to then set status-ipv4/status-ipv6 instead of status, ipv4/ipv6 instead of ip and so on.

I admit the rules for this aren't clearly written down yet, we went over some details in this pull request (while in a fork, so other repo): rrthomas#10

@TinfoilSubmarine
Copy link
Contributor Author

Is this better? I also added skipping the update if the record is already set to the same IP.

@TinfoilSubmarine TinfoilSubmarine changed the title gandi: update logic to allow updating IPv6/AAAA gandi improvements Aug 2, 2023
@TinfoilSubmarine
Copy link
Contributor Author

FYI, I'm done making revisions on this.

@LenardHess
Copy link
Contributor

Thanks for the update (again 😉)

We will leave this pull request open until v3.11.0 has been released (see #552 (comment) for details). It will get pulled into v3.11.1

@LenardHess LenardHess added provider Adds, fixes or removes a provider. not-in-this-release Won't yet be handled in the upcoming release labels Aug 12, 2023
@LenardHess
Copy link
Contributor

Same as #557 - please rebase onto master for the merge.

@LenardHess LenardHess removed the not-in-this-release Won't yet be handled in the upcoming release label Oct 21, 2023
ddclient.in Outdated Show resolved Hide resolved
Copy link
Contributor

@LenardHess LenardHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a few things i still noticed - Apologies for not noticing them the first time around.
The "Nitpick" stuff isn't urgent, feel free to skip those suggestions.

ddclient.in Outdated Show resolved Hide resolved
ddclient.in Outdated Show resolved Hide resolved
ddclient.in Outdated Show resolved Hide resolved
ddclient.in Show resolved Hide resolved
- allow updating IPv6/AAAA
- allow updating A and AAAA records simultaneously
- skip updating if record already has same IP
Copy link
Contributor

@LenardHess LenardHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@LenardHess LenardHess merged commit e0611ab into ddclient:master Nov 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider Adds, fixes or removes a provider.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants