-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gandi improvements #558
gandi improvements #558
Conversation
When using I admit the rules for this aren't clearly written down yet, we went over some details in this pull request (while in a fork, so other repo): rrthomas#10 |
09ea180
to
08a8ba1
Compare
Is this better? I also added skipping the update if the record is already set to the same IP. |
0a23439
to
451de37
Compare
FYI, I'm done making revisions on this. |
Thanks for the update (again 😉) We will leave this pull request open until v3.11.0 has been released (see #552 (comment) for details). It will get pulled into v3.11.1 |
Same as #557 - please rebase onto master for the merge. |
58139b0
to
bb7ab9d
Compare
bb7ab9d
to
6c262e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a few things i still noticed - Apologies for not noticing them the first time around.
The "Nitpick" stuff isn't urgent, feel free to skip those suggestions.
62b82c7
to
b0a7267
Compare
- allow updating IPv6/AAAA - allow updating A and AAAA records simultaneously - skip updating if record already has same IP
b0a7267
to
846ab59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
No description provided.