Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP 30x redirections in curl requests (fix issue #589) #592

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

sphakka
Copy link
Contributor

@sphakka sphakka commented Nov 7, 2023

Enable HTTP 30x redirections in curl requests -- fix issue #589:

  • curl: enable a configurable number of redirections (-redirects=<max>) to follow when making HTTP(S) requests.
  • docs: update Infomaniak example to prefer 'dyndns2' instead of obsolete protocol.

Test

F.i., with Infomaniak:

$ cat > /tmp/ddclient.conf <<EOF
pid=/tmp/ddclient.pid           
ssl=yes

protocol=dyndns2
use=web, web=infomaniak.com/ip.php/
server=infomaniak.com
login=$login
password=$password
# uncomment to test without CLI option -redirect
#redirect=2
$host      
EOF

Then:

$ ddclient -file=/tmp/ddclient.conf -daemon=0 -debug -verbose -noquiet -redirect=2

…Issue ddclient#589

- curl: enable a configurable number of redirections (-redirects=<max>) to
  follow when making HTTP(S) requests.
- docs: update Infomaniak example to prefer 'dyndns2' instead of obsolete
  protocol.

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
@LenardHess
Copy link
Contributor

Merged 👍

For any future pull request, please separate different changes into separate commits or even separate pull requests.
I.e. in the PR we had changes to curl, changes to Infomaniak and random whitespace cleanup - all of which are not related. This makes it more tedious to traverse the history later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants