-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source file of the 'ddd_on_a_page.jpg' image #3
Comments
Hey, That's totally fine. I don't think anyone will have any complaints about that. Here's the Miro board where you can access all of the content: https://miro.com/app/board/o9J_laNkYxM=/?invite_link_id=905090973975 |
Thank you! We were able to create a copy, so I'm going to mark the issue as closed. |
would you add the translation to this repo? We already got some questions on a PR for a Japanese translation, for example. |
Hi @yellowbrickc, Sorry for the delay! Currently we have created a repo with the Spanish translation: (I hope https://github.com/osoco/bienvenida-a-ddd/tree/traduccion_p%C3%A1gina will be merged soon with all the content translated) I can copy this translation to something as https://github.com/ddd-crew/welcome-to-ddd/translations/es, include a link within https://github.com/ddd-crew/welcome-to-ddd/README.md to it and create you a pull request. Another option can be adding a link within https://github.com/ddd-crew/welcome-to-ddd/README.md to our repo. Which option fits you better? |
Great, thank you for your contribution! I am a big fan of ownership and empowerment and you already own the translations (I don't know if anybody in @ddd-crew/crew team can and wants to review PRs in Spanish 😉 ), so including the link in the Readme would suffice, IMO. The only pro-argument for adding it to this repo is that in that case, others can see it and follow your example. What do you think @ddd-crew/crew ? Additionally, there is a special "feature" not directly visible here: the site https://virtualddd.com/learning-ddd renders the content of these repos in ddd-crew. If we keep the Spanish (and hopefully other) translations in one place, they will be included automatically. Otherwise, you can create a PR for https://github.com/Virtual-Domain-driven-design/virtual-domain-driven-design to add it to the rendered repos when the PR is merged. All this of course only if you want the content to be available on the Virtual DDD site (you don't have to). What would you prefer? |
Hi Krisztina, We're currently fixing a couple of typos in the Spanish translation in our repository. Once the revision will be finished I'll create a PR in your repository with a copy of the translation within the directory |
Hi,
Some folks and me are interested in translating the contents of the ddd-crew repositories to Spanish.
Our first approach is to translate this repository and we were wondering if the source file of the ddd_on_a_page.jpg image can be pushed (miro, drawio, psd, etc). This will help us to translate it.
Thanks in advance
Regards
The text was updated successfully, but these errors were encountered: