-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
developer requests #146
Comments
As for making the search window resizable, I'll do this asap. |
Awesome reply!
For synced lyrics, I previously used https://www.musixmatch.com/ but I
don't know if it is free to get lyrics from them.
Otherwise if not too difficult to implement... allow user to add/paste his
own lyrics? I would LOVE the ability to add/edit my own lyrics (and then
sync)! Often, I can find the lyrics but maybe they are not synchronised.
Maybe users can get the synced lyrincs from musicmatch and copy/paste into
LyricsX? Any option would be great.
p.s. small technical issue... when doing search, I believe the app should
perform the search when hitting "enter" key also, in addition to pressing
the search button.
pss I really really appreciate this app!
…--
Cheers,
Scott
From: ddddxxx <notifications@github.com>
Reply-To: ddddxxx/LyricsX
<reply+01b35fddd28cb37b67a7cc06e5e96c2dd11595321b23b81592cf0000000116e1a7bb9
2a169ce129d1c91@reply.github.com>
Date: Sun, 08 Apr 2018 02:49:47 -0700
To: ddddxxx/LyricsX <LyricsX@noreply.github.com>
Cc: Scott Flore <scott.flore@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [ddddxxx/LyricsX] developer requests (#146)
1. I'm glad to hear my app helps you, thank you.
2. Accepted.
3. I've heard a lot of similar requests, and would like to implement it.
However I don't have external display... I'll do it whenever possible.
4. Another common request. If you know where can I find free and synced
lyrics, just tell me :)
As for making the search window resizable, I'll do this asap.
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3fHh-pUPwaYB4gGXlthjK
91ZWxXbks5tmd07gaJpZM4TLc4a> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4b
b","name":"GitHub"},"entity":{"external_key":"github/ddddxxx/LyricsX","title
":"ddddxxx/LyricsX","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143
418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"h
ttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6
-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ddddxxx/LyricsX"}},"updates":{"snippets":[
{"icon":"PERSON","message":"@ddddxxx in #146: 0. I'm glad to hear my app
helps you, thank you.\r\n1. Accepted.\r\n2. I've heard a lot of similar
requests, and would like to implement it. However I don't have external
display... I'll do it whenever possible.\r\n3. Another common request. If
you know where can I find **free** and **synced** lyrics, just tell me
:)\r\n\r\nAs for making the search window resizable, I'll do this
asap."}],"action":{"name":"View
Issue","url":"#146 (comment)
536878"}}}
|
Musixmatch, provides commercial license. It's way too expensive, and store lyrics file into user's hard drive without encryption violate their policy. Actually I think no one can provide such agreement. You can import your own lyrics, by dragging them into lyrics window. They must be standard lyrics format (LRC). |
awesome! thanks
From: ddddxxx <notifications@github.com>
Reply-To: ddddxxx/LyricsX
<reply+01b35fddeece77c81d6277cb1f2926dd776a0da1b72a8e3d92cf0000000116e2bf2e9
2a169ce129d1c91@reply.github.com>
Date: Sun, 08 Apr 2018 22:42:06 -0700
To: ddddxxx/LyricsX <LyricsX@noreply.github.com>
Cc: Scott Flore <scott.flore@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [ddddxxx/LyricsX] developer requests (#146)
Musixmatch, provides commercial license. It's way too expensive, and store
lyrics file into user's hard drive without encryption violate their policy.
Actually I think no one can provide such agreement.
You can import your own lyrics, by dragging them into lyrics window. They
must be standard lyrics format (LRC)
<https://en.wikipedia.org/wiki/LRC_(file_format)> .
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3epO-DQmYO40FY5B5gNC3
RbolX5gks5tmvSugaJpZM4TLc4a> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4b
b","name":"GitHub"},"entity":{"external_key":"github/ddddxxx/LyricsX","title
":"ddddxxx/LyricsX","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143
418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"h
ttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6
-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ddddxxx/LyricsX"}},"updates":{"snippets":[
{"icon":"PERSON","message":"@ddddxxx in #146: Musixmatch, provides
commercial license. It's way too expensive, and store lyrics file into
user's hard drive without encryption violate their policy. Actually I think
no one can provide such agreement.\r\n\r\nYou can import your own lyrics, by
dragging them into lyrics window. They must be [standard lyrics format
(LRC)](https://en.wikipedia.org/wiki/LRC_(file_format))."}],"action":{"name"
:"View
Issue","url":"#146 (comment)
638716"}}}
|
Hi.... sorry I'm having trouble dragging lyrics into the the lyrics window.
When I drag and drop nothing happens. Maybe I am doing something wrong. I
used one lyrics file already saved from the Lyricx folder so I know it is
correct format.
From: ddddxxx <notifications@github.com>
Reply-To: ddddxxx/LyricsX
<reply+01b35fddeece77c81d6277cb1f2926dd776a0da1b72a8e3d92cf0000000116e2bf2e9
2a169ce129d1c91@reply.github.com>
Date: Sun, 08 Apr 2018 22:42:06 -0700
To: ddddxxx/LyricsX <LyricsX@noreply.github.com>
Cc: Scott Flore <scott.flore@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [ddddxxx/LyricsX] developer requests (#146)
Musixmatch, provides commercial license. It's way too expensive, and store
lyrics file into user's hard drive without encryption violate their policy.
Actually I think no one can provide such agreement.
You can import your own lyrics, by dragging them into lyrics window. They
must be standard lyrics format (LRC)
<https://en.wikipedia.org/wiki/LRC_(file_format)> .
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3epO-DQmYO40FY5B5gNC3
RbolX5gks5tmvSugaJpZM4TLc4a> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4b
b","name":"GitHub"},"entity":{"external_key":"github/ddddxxx/LyricsX","title
":"ddddxxx/LyricsX","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143
418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"h
ttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6
-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ddddxxx/LyricsX"}},"updates":{"snippets":[
{"icon":"PERSON","message":"@ddddxxx in #146: Musixmatch, provides
commercial license. It's way too expensive, and store lyrics file into
user's hard drive without encryption violate their policy. Actually I think
no one can provide such agreement.\r\n\r\nYou can import your own lyrics, by
dragging them into lyrics window. They must be [standard lyrics format
(LRC)](https://en.wikipedia.org/wiki/LRC_(file_format))."}],"action":{"name"
:"View
Issue","url":"#146 (comment)
638716"}}}
|
lyrics window, not karaoke lyrics. |
ok thanks I figured it out... drag raw text from the editor to the window...
not the file 😜
From: ddddxxx <notifications@github.com>
Reply-To: ddddxxx/LyricsX
<reply+01b35fddc10fa72d750010f907b588abad8d010054866b8492cf0000000116e2c95f9
2a169ce129d1c91@reply.github.com>
Date: Mon, 09 Apr 2018 06:25:35 +0000 (UTC)
To: ddddxxx/LyricsX <LyricsX@noreply.github.com>
Cc: Scott Flore <scott.flore@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [ddddxxx/LyricsX] developer requests (#146)
lyrics window, not karaoke lyrics.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3VZgfw1k-FKYYuBZORjbo
ThvzKNxks5tmv7fgaJpZM4TLc4a> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4b
b","name":"GitHub"},"entity":{"external_key":"github/ddddxxx/LyricsX","title
":"ddddxxx/LyricsX","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143
418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"h
ttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6
-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ddddxxx/LyricsX"}},"updates":{"snippets":[
{"icon":"PERSON","message":"@ddddxxx in #146: lyrics window, not karaoke
lyrics."}],"action":{"name":"View
Issue","url":"#146 (comment)
646985"}}}
|
Dragging files should also work. When you drag files, is there a green plus icon beside your mouse, indicate the window accept what you drags? |
nope... won't work with drag file... no green plus icon when dragging
file... strange (maybe something wrong with my computer if it works for you)
From: ddddxxx <notifications@github.com>
Reply-To: ddddxxx/LyricsX
<reply+01b35fdd15b902e2447af96229d2fab86d34e49c290819d892cf0000000116e2cdec9
2a169ce129d1c91@reply.github.com>
Date: Mon, 09 Apr 2018 06:45:00 +0000 (UTC)
To: ddddxxx/LyricsX <LyricsX@noreply.github.com>
Cc: Scott Flore <scott.flore@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [ddddxxx/LyricsX] developer requests (#146)
Dragging files should also work.
When you drag files, is there a green plus icon beside your mouse, indicate
the window accept what you drags?
�
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3UUBolZAvcmaOMMsWFd5F
JVGYMQrks5tmwNsgaJpZM4TLc4a> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4b
b","name":"GitHub"},"entity":{"external_key":"github/ddddxxx/LyricsX","title
":"ddddxxx/LyricsX","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143
418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"h
ttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6
-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ddddxxx/LyricsX"}},"updates":{"snippets":[
{"icon":"PERSON","message":"@ddddxxx in #146: Dragging files should also
work.\r\n\r\nWhen you drag files, is there a green plus icon beside your
mouse, indicate the window accept what you drags?"}],"action":{"name":"View
Issue","url":"#146 (comment)
651054"}}}
|
my bad. It won't work since 1.2.3. I've fixed that in 1.3.0. |
By the way... appreciate the update... but LyricsX is crashing sometimes
now.
Also you might know that when LyricsX finds lyrics which was previously
found under the old version, LyricsX-update "forgets" the Offset previously
set with the old version. I could successfully recover the old version by
dragging from the Finder, but only useful for the old "non-karoke-word-sync"
lyrics.
Thanks again for the update... and I am desperately looking forward to the
built-in editor. That would make it just perfect! 😄
From: ddddxxx <notifications@github.com>
Reply-To: ddddxxx/LyricsX
<reply+01b35fdd2625d0522c5a265edd1b8d99b9a3fa769908f32192cf0000000116e2d6a49
2a169ce129d1c91@reply.github.com>
Date: Mon, 09 Apr 2018 07:22:12 +0000 (UTC)
To: ddddxxx/LyricsX <LyricsX@noreply.github.com>
Cc: Scott Flore <scott.flore@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [ddddxxx/LyricsX] developer requests (#146)
my bad. It won't work since 1.2.3. I've fixed that
<29826a2> .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3S-8kXnD7KSI2j0hiwkQl
BjqOcCgks5tmwwkgaJpZM4TLc4a> .
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4b
b","name":"GitHub"},"entity":{"external_key":"github/ddddxxx/LyricsX","title
":"ddddxxx/LyricsX","subtitle":"GitHub
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143
418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"h
ttps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6
-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/ddddxxx/LyricsX"}},"updates":{"snippets":[
{"icon":"PERSON","message":"@ddddxxx in #146: my bad. It won't work since
1.2.3. [I've fixed
that](https://github.com/ddddxxx/LyricsX/commit/29826a2)."}],"action":{"name
":"View
Issue","url":"#146 (comment)
658755"}}}
|
1.3.0 does get terrible crash rate. I'm working on that. The old LRC format doesn't support word time tag. Therefore I introduced a new format called LRCX. The app still read LRC file. meanwhile it search new lyrics and create a LRCX file. I don't know if two version of the lyrics are originally the same, so I don't transfer any data from old version. |
thanks for the email... I understand but want to suggest if maybe the
offset could be transferred by adding or subtracting the old offset from
all the new LRCX timestamps found (download the new LRCX and then apply the
offset to every timestamp)? Maybe too complicated but thought i would just
suggest.
…On 26 April 2018 at 10:53, ddddxxx ***@***.***> wrote:
1.3.0 does get terrible crash rate. I'm working on that.
The old LRC format doesn't support word time tag. Therefore I introduced a
new format called LRCX. The app still read LRC file. meanwhile it search
new lyrics and create a LRCX file. I don't know if two version of the
lyrics are originally the same, so I don't transfer any data from old
version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3WaansNDb2Jc5rYUl8M2tgkhHRHJks5tsW7YgaJpZM4TLc4a>
.
|
It's too complicated, I don't plan to do such thing. Once global offset is done, you need to reset most of them anyway, right? |
ok
…On 26 April 2018 at 12:08, ddddxxx ***@***.***> wrote:
It's too complicated, I don't plan to do such thing. Once global offset is
done, you need to reset most of them anyway, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AbNf3acuIYv5X4KEzzTg8jpuzXe_zUNJks5tsYCbgaJpZM4TLc4a>
.
|
With v1.4.2, you can drag lyrics window cross screen. |
Love the app and really really appreciate it. However I have a few requests:
For the rest is quite impressive. Maybe also make the search window resizable. At present is only about 5-6 lines and cannot be enlarged to show more results without scrolling.
The text was updated successfully, but these errors were encountered: