Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer requests #146

Closed
TheScottMan opened this issue Apr 8, 2018 · 17 comments
Closed

developer requests #146

TheScottMan opened this issue Apr 8, 2018 · 17 comments

Comments

@TheScottMan
Copy link

Love the app and really really appreciate it. However I have a few requests:

  1. Please offer an option for "universal" offset... all songs sync normally off by 2 sec. to start
  2. Would appreciate option to choose which display to show lyrics on. Would rather have one display dedicated for lyrics rather than mirror entire desktop to secondary display ('Karoke mode').
  3. Offer more sources for lyric search (international)

For the rest is quite impressive. Maybe also make the search window resizable. At present is only about 5-6 lines and cannot be enlarged to show more results without scrolling.

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 8, 2018

  1. I'm glad to hear my app helps you, thank you.
  2. Accepted.
  3. I've heard a lot of similar requests, and would like to implement it. However I don't have external display... I'll do it whenever possible.
  4. Another common request. If you know where can I find free and synced lyrics, just tell me :)

As for making the search window resizable, I'll do this asap.

@TheScottMan
Copy link
Author

TheScottMan commented Apr 9, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 9, 2018

Musixmatch, provides commercial license. It's way too expensive, and store lyrics file into user's hard drive without encryption violate their policy. Actually I think no one can provide such agreement.

You can import your own lyrics, by dragging them into lyrics window. They must be standard lyrics format (LRC).

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 9, 2018

You can find all the lyrics in ~/Music/LyricsX/. feel free to edit them.

before I implement build-in lyrics editor (#65), you can sync lyrics using online lyrics editor, like this.

@TheScottMan
Copy link
Author

TheScottMan commented Apr 9, 2018 via email

@TheScottMan
Copy link
Author

TheScottMan commented Apr 9, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 9, 2018

lyrics window, not karaoke lyrics.

@TheScottMan
Copy link
Author

TheScottMan commented Apr 9, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 9, 2018

Dragging files should also work.

When you drag files, is there a green plus icon beside your mouse, indicate the window accept what you drags?

@TheScottMan
Copy link
Author

TheScottMan commented Apr 9, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 9, 2018

my bad. It won't work since 1.2.3. I've fixed that in 1.3.0.

@TheScottMan
Copy link
Author

TheScottMan commented Apr 25, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 26, 2018

1.3.0 does get terrible crash rate. I'm working on that.

The old LRC format doesn't support word time tag. Therefore I introduced a new format called LRCX. The app still read LRC file. meanwhile it search new lyrics and create a LRCX file. I don't know if two version of the lyrics are originally the same, so I don't transfer any data from old version.

@TheScottMan
Copy link
Author

TheScottMan commented Apr 26, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Apr 26, 2018

It's too complicated, I don't plan to do such thing. Once global offset is done, you need to reset most of them anyway, right?

@TheScottMan
Copy link
Author

TheScottMan commented Apr 26, 2018 via email

@ddddxxx
Copy link
Owner

ddddxxx commented Oct 10, 2018

With v1.4.2, you can drag lyrics window cross screen.

@ddddxxx ddddxxx closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants