Message: From header can be absent (#242)

Close #241
ddeboer · Oct 12, 2017 · 034d0f9 · 034d0f9
2 parents 63d472b + f8b4d15
commit 034d0f9
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 4 deletions.
diff --git a/src/Message/AbstractMessage.php b/src/Message/AbstractMessage.php
@@ -26,9 +26,9 @@ final public function getId(): string
     /**
      * Get message sender (from headers).
      *
-     * @return EmailAddress
+     * @return null|EmailAddress
      */
-    final public function getFrom(): EmailAddress
+    final public function getFrom()
     {
         return $this->getHeaders()->get('from');
     }

diff --git a/src/Message/BasicMessageInterface.php b/src/Message/BasicMessageInterface.php
@@ -39,9 +39,9 @@ public function getId(): string;
     /**
      * Get message sender (from headers).
      *
-     * @return EmailAddress
+     * @return null|EmailAddress
      */
-    public function getFrom(): EmailAddress;
+    public function getFrom();
 
     /**
      * Get To recipients.

diff --git a/tests/MessageTest.php b/tests/MessageTest.php
@@ -650,6 +650,14 @@ public function testInlineAttachment()
         $this->assertNull($inline->getFilename());
     }
 
+    public function testMissingFromHeader()
+    {
+        $this->mailbox->addMessage($this->getFixture('missing_from'));
+        $message = $this->mailbox->getMessage(1);
+
+        $this->assertNull($message->getFrom());
+    }
+
     public function testAttachmentMustNotBeCharsetDecoded()
     {
         $parts = [];

diff --git a/tests/fixtures/missing_from.eml b/tests/fixtures/missing_from.eml
@@ -0,0 +1,7 @@
+To: to@here.com
+Subject: Nuu
+Date: Wed, 13 Sep 2017 13:05:45 +0200
+Content-Type: text/plain; charset="us-ascii"
+Content-Transfer-Encoding: quoted-printable
+
+Hi