Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need getAll for headers #200

Closed
Lewiscowles1986 opened this issue Sep 28, 2017 · 1 comment
Closed

Need getAll for headers #200

Lewiscowles1986 opened this issue Sep 28, 2017 · 1 comment
Labels
enhancement
Milestone
1.0

Comments

@Lewiscowles1986
Copy link

Because Headers and parent class Parameters are not Iterable it's impossible to get headers if you don't know what the headers are.

Also in some cases, it would be more useful to return all headers within an array than to iterate over them (cost of copy vs iteration where copy or filter would be implemented)
@Slamdunk Slamdunk added this to the 1.0 milestone Sep 29, 2017
@Slamdunk Slamdunk mentioned this issue Oct 2, 2017
Merged
Slamdunk added a commit that referenced this issue Oct 2, 2017
@Slamdunk
Merge pull request #215 from Slamdunk/get_all_headers
4ad1cfd 
Headers now extends \ArrayIterator
Close #200
@Slamdunk
Copy link
Collaborator

Slamdunk commented Oct 2, 2017

Implemented in #215 thank you for the feedback

@Slamdunk Slamdunk closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@Slamdunk @Lewiscowles1986