Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coding-standards #181

Merged
merged 5 commits into from Sep 26, 2017
Merged

Add coding-standards #181

merged 5 commits into from Sep 26, 2017

Conversation

Slamdunk
Copy link
Collaborator

  • Add coding-standards configuration file for PHP-CS-Fixer
  • Travis: enable coding-standards check to force adherence for commits and PRs
  • Apply new coding-standards rules
  • Fix tests errors emerged with new coding-standards

@Slamdunk Slamdunk added this to the 1.0 milestone Sep 25, 2017
@Slamdunk
Copy link
Collaborator Author

@ddeboer the most notable change here is the declare(strict_types=1); declaration added to all the files.
It emerged three errors like:
https://travis-ci.org/Slamdunk/imap/jobs/279420279#L690
that needed these three fixes:
dfb3666

@Slamdunk Slamdunk merged commit c4e1b91 into ddeboer:develop Sep 26, 2017
@Slamdunk Slamdunk deleted the coding_standards branch September 26, 2017 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddeboer ddeboer Awaiting requested review from ddeboer

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Slamdunk