Fixes ddeboer/imap#66 #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utf8_encode function encodes ONLY ISO-8859-1 string to UTF-8. Instead of utf8_encode it should be used iconv()
Headers to and from are instance of EmailAddress, but reply_to, cc, sender are arrays. It should have the same type.
| $this->array['reply_to'] = $recipients; | ||
| } else { | ||
| $this->array['reply_to'] = array(); | ||
| } |
There was a problem hiding this comment.
What do these changes have to do with the encoding fix?
There was a problem hiding this comment.
This was supposed to be different pull request, but It merge to one pull request. I don't know why
There was a problem hiding this comment.
I understand. Could you undo the last commit so we keep this PR clean?
|
Fixes #66 (correcting the reference here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf8_encode function encodes ONLY ISO-8859-1 string to UTF-8. Instead of utf8_encode it should be used iconv()