Test enhancement

[peter279k]

Changed log

• Use expectedException annotation to be compatible with the different PHPUnit version.
• Use the ::class approach directly in assertInstanceOf expected object.

[andreasschroth]

Imo, useful changes, although I'd keep the setExpectedException() call explicitly in the code, as it's less explicit in the PHPDOC block.

[peter279k]

@andreasschroth, thank you for reply.
I use the expectedException annotation because the PHPUnit has the different way to call the expected exception method in different versions.

The PHPUnit version is less than 5.7, and it will be the setExpectedException().
When the PHPUnit version is 6.5+, it will be the expectException().

Set the multiple PHPUnit versions is necessary because it let PHPUnit support the multiple PHP versions. You can see more details in official PHPUnit website.

Using the expectedException annotation to be compatible with the different expected exception.

[andreasschroth]

@peter279k Well okay, thanks for the explanation, that makes absolutely sense. I guess in general it might just make sense to remove PHP 5.x support all together within this library, so it can also make use of the latest features.

[peter279k]

@andreasschroth .Thank you for your reply.
I agree with your suggestion. If we remove the php-5.x support, this problem I mention will not be existed.

It can use the expectException method directly and remove the annotation of expected exception.
But I think the owner @ddeboer will be accepted this ,too.

[ddeboer]

Thanks for the improvements! We should drop PHP 5 support in a separate PR.