Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Switzerland to the list of available VAT ID formats #28

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Added Switzerland to the list of available VAT ID formats #28

merged 1 commit into from
Jan 5, 2019

Conversation

alexanderglueck
Copy link
Contributor

Added CH validation rule and tests.

Furthermore, I had to increase the whitespaces because the CH check would have ruined the alignment of the comments.

@ddeboer ddeboer merged commit 496006d into ddeboer:master Jan 5, 2019
@ddeboer
Copy link
Owner

ddeboer commented Jan 5, 2019

Cool, thanks!

@GrahamCampbell
Copy link
Contributor

Isn't [0-9]{9,9} just \d{9}. The longer format makes the expression much larger than actually needed.

@alexanderglueck
Copy link
Contributor Author

Yes, just tried it and it still works the same. Good catch!

@GrahamCampbell
Copy link
Contributor

I sent a PR a few hours ago. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexanderglueck @ddeboer @GrahamCampbell