-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how the program listening are killed #17
Conversation
Following recommendations from http://unix.stackexchange.com/a/8927, I introduced a softer way of terminating the programs listening on the wanted port.
Nice I was not aware of that. From a quick glance this lgtm, but will probably wait off on merging this until later tonight when I am off work and can look at it. |
sure |
Quick question. |
yea so when I was developing this heavily I ran into the problem alot. Then once I published it and used the package myself I never had any issues so that was why I commented it out. I meant to revisit it at some point but I forgot. |
Maybe a flag should be added like -f or --force and that would trigger the change you made? |
That could be helpful in some cases. |
That would allow all the current users to upgrade and use the package the exact same way with no change to functionality. So I will merge this as is and I will add that flag / option myself or if you want to update your PR with that change before I merge it thats fine too. Just so you are aware. |
I'd rather let you add the flag. |
Ok cool, merging. |
Following recommendations from http://unix.stackexchange.com/a/8927, I introduced a softer way of terminating the programs listening on the wanted port.