Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 filters #1

Closed
wants to merge 5 commits into from
Closed

4 filters #1

wants to merge 5 commits into from

Conversation

jliljebl
Copy link
Contributor

@jliljebl jliljebl commented Jun 6, 2012

Patches add four filters and CMakeLists.txt files for them.

Build files in parent folder are not touched, so to build filters those build files need to modified, for both cmake and autotools builds.

Filters are:

Posterize
Dither
Emboss
Spillsupress

@ddennedy
Copy link
Owner

ddennedy commented Jun 7, 2012

In frei0r, all double parameters must be in the range [0, 1] but I see a comment like this in dither: // range 2 - 50.
and "matrixid = CLAMP(matrixid, 0, 9);" in the code.

So, this is not compliant. See how Marko has done some mapping of ranges in some of his plugins such as select0r. Yes, I know this is a pain, but it is necessary.

@jliljebl
Copy link
Contributor Author

jliljebl commented Jun 7, 2012

In frei0r, all double parameters must be in the range [0, 1] b

Okay, will fix.

I'll send another pull request once I've made code Frei0r compliant.

@ddennedy
Copy link
Owner

ddennedy commented Jun 7, 2012

On Wed, Jun 6, 2012 at 10:47 PM, jliljebl
reply@reply.github.com
wrote:

In frei0r, all double parameters must be in the range [0, 1] b

Okay, will fix.

P.S. I have a commit in my local tree that adds them to both build
systems, and I have done basic compile and execute tests. So, this is
probably the only problem I find.

@jliljebl
Copy link
Contributor Author

jliljebl commented Jun 7, 2012

I have added another commit to pull request that fixes all double
parameters to use input range 0.0 - 1.0, as per Frei0r requirements.

@ddennedy
Copy link
Owner

ddennedy commented Jun 9, 2012

merged manually and pushed to code.dyne.org

@ddennedy ddennedy closed this Jun 9, 2012
@jliljebl
Copy link
Contributor Author

jliljebl commented Jun 9, 2012

Great, thanks.

ddennedy pushed a commit that referenced this pull request Sep 12, 2020
Correction for cylindrical hue term distance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants