-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First class new GitHub UI support! #44
base: master
Are you sure you want to change the base?
Conversation
Love this!!! |
@kdev would you mind helping me testing this? |
Hey @zardoy, I'm up for some tests! 👍 |
Okay, so you can either build it youself or I can attach extension zip once I update all icons from vscode-icons repo (they are pretty outdated). |
I would prefer a zip of some sort |
@kdev I love testers! And I finally managed to publish new npm version with svgs of vscode-icons and now made extension with latest vscode-icons icons: Feel free to provide feedback to let me know wether everything is good! For example now https://github.com/bgrins/TinyColor has deno.lock icon, but it seems we don't support dark theme 🤔 |
Any plans on bringing this to Firefox? |
Currently, it doesn't work with Firefox, I don't know why atm. Not sure how hard it would be to publish. I may look at all this later. |
I ran the crx through https://www.extensiontest.com and got the results below Results
|
I believe this thing is outdated, manifest v3 is supported by Firefox. I was using |
@zardoy First of all thanks for this update, It works great! I just wanted to request the feature to support icons in the search results. Thanks in advance. ![]() |
hey @zardoy - love your work! Do you plan maintaining it for longer? |
thx
For this one - yes. But I'm a single dev 5 actively running projects so I don't have much time to think of code changes on other projects like this one, sorry. will focus on this one a and fix the breakage once I have time for it :) |
No worries, take your time! I'd love to support you but I'm afraid my dev-skills aren't even remotely enough for that. |
Hey all! Sorry, completely forgot about this one, and no one reminded :( Now finally I'm here with all UI breakages fixed, enjoy! |
fixes #40
fixes #39
fixes #42
closes #43
Current tests are failing, though I didn't touch them as new UI only available when logged in.
@dderevjanik
I rly miss icons in new ui so if it don't get merged in within a few weeks I'll publish it to chrome extensions storehttps://chrome.google.com/webstore/detail/github-vscode-icons-updat/amefmmaoenlhckgaoppgnmhlcolehkhoNew UI: Now icons everywhere!
Screenshots
New file list and sidebar:
Commands pallete:
And as a bonus (even github doesn't show icons in this location),
File search:
No support for: modules, symlinks, old-style files search (
t
) (will be removed soon)