Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev-drupal-solr is obsolete #40

Open
mkalkbrenner opened this issue May 7, 2024 · 7 comments
Open

ddev-drupal-solr is obsolete #40

mkalkbrenner opened this issue May 7, 2024 · 7 comments

Comments

@mkalkbrenner
Copy link
Collaborator

I carefully read the README of ddev-drupal-solr. Everything described there could be done with ddev-solr 0.4.0.
The only difference is that the downloaded config.zip has to be extracted to .ddev/solr/configsets/<CORE_NAME>/ instead of .ddev/solr/conf/.
(That would automatically solve #37 )

I suggest to convert this add-on. It should depend on ddev-solr and just contain the drupal-specific documentation, examples and tests. And maybe som convenient ddev commands that hide complex options of the drush commands.

See ddev/ddev-solr#14 (comment)

@mkalkbrenner
Copy link
Collaborator Author

For my own projects I created a custom ddev index-parallel command that is specific for drupal's search_api and speeds up indexing. That would perfectly fit into this "new" ddev-drupal-solr add-on.

@rfay
Copy link
Member

rfay commented May 7, 2024

We have definitely been trying to move it toward obsolescence, nothing the preference of ddev-solr in the README, etc. Perhaps the next step would be to archive it and make a stronger statement in the README.

@mkalkbrenner
Copy link
Collaborator Author

@rfay What about the suggestion to let it depend on ddev-solr and move the drupal-specific stuff here:

  • documentation how to setup Search API Solr with Solr Cloud in cloud or standalone mode.
  • add a command to deploy the jump-start configsets Acquia, Hosted Solr and Serach Stax are using
  • add convenience commands like index-parallel

@rfay
Copy link
Member

rfay commented May 7, 2024

I like it!

It would require a new major release and maybe something that explained it. As you know, DDEV doesn't currently auto-download.

@rfay
Copy link
Member

rfay commented May 7, 2024

I invited you as a maintainer of this repo, as always most things are done in issues and PRs anyway. Maybe others who have commented previously will speak up about this proposal. It probably needs a separate issue.

@mkalkbrenner
Copy link
Collaborator Author

@rfay I started working on it. And the migration of the Solr 8 core to a Solr 9 collection already works :-)

#41

@mkalkbrenner
Copy link
Collaborator Author

mkalkbrenner commented May 8, 2024

Migration

Install the old version

ddev get ddev/ddev-drupal-solr
ddev restart

Bildschirmfoto 2024-05-09 um 00 57 27

Update to new version

ddev stop
ddev get ddev/ddev-solr
ddev get <PATH_TO_PR_41_CLONE>/ddev-drupal-solr
ddev restart

Bildschirmfoto 2024-05-09 um 01 13 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants