Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Drupal settings workflow #16

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Feb 1, 2023

This PR updates the installation steps as followed:

  • Remove duplicate "Choose Solr as backend."
  • Settings now flow in same order as displayed on page.
  • Consistent use of backtacks for actual settings.
  • Improve nested setting locations.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks!

@rfay rfay merged commit 9b96fb3 into ddev:main Feb 1, 2023
@rfay
Copy link
Member

rfay commented Feb 1, 2023

Manually tested and it worked fine.

@tyler36 tyler36 deleted the tyler36/doc_setup branch February 2, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants