Refactor computeLink function and event listeners, fixes #30 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor computeLink function to improve readability and security: - Replace innerHTML with textContent when setting the ddevLinkElement content for enhanced security and performance. - Initialize URL link on page load by calling computeLink function. - Streamline event listener attachment for form elements with a 'name' attribute within the 'target' element. - Attach updateArtifacts function as an event listener to the 'ddev-repo' input field to handle updates.
|
Thanks so much for this. Does this mean that in the entire history of this ddev-gitpod-launcher it always failed and nobody ever reported the failure? |
|
Gave you full privs on this repo. |
|
But of course please see much simpler Also please provide manual testing instructions. |
|
@rfay I added now testing steps in the description |
rfay
changed the title
|
Thanks to you both for fixing this :) -mike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the
Pagessettings of my repo, you can test it here -https://shaal.github.io/ddev-gitpod-launcher/
Notice that with this PR every keystroke immediately updates the link.
Fixes