-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PLATFORM_RELATIONSHIPS, fixes #9 #48
Conversation
generate_db_relationship.sh
Outdated
"scheme": "${dbscheme}", | ||
"service": "${dbservice}", | ||
"fragment": null, | ||
"ip": "169.254.118.116", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an fixed IP in DDEV or just dummy? (same question for the other services below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dummy. I'm hoping nothing uses it. It would be better as an obvious dummy, like 255.255.255.255. If it's actually used, we would have to figure it out at ddev start
time instead of here, which may be what we want anyway. So worth considering moving all this generation to ddev start
time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also would be reasonable to put hostname here, but not sure if that would break something. Changed this to use 255.255.255.255 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. We can't use a hostname here, since we have a dedicated hostname
property.
We'll probably need to indeed figure it out at ddev start
, but this may be a follow-up task.
WDYT @gilzow ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the services (DB, elasticsearch, memcached, redis) change e.g. the port they expose?
Co-authored-by: Jérôme Vieilledent <lolautruche@gmail.com>
It would also be reasonable to put a hostname here.
5964328
to
78f15a5
Compare
This is great! |
DDEV automatically provides platform.yaml (and has for several months). It's the version that was originally developed for the add-on. And |
.platform.app.yaml
andservices.yaml
#9This implements PLATFORM_RELATIONSHIPS with local DDEV-based values.
This can be tested with
TODO: