Blog: MariaDB breaking change in dump format #210

rfay · 2024-06-13T17:36:46Z

The Issue

Blog about MariaDB breaking change in dump format

Rendered at https://20240613-mariadb.ddev-com-front-end.pages.dev/blog/mariadb-dump-breaking-change/

cloudflare-pages · 2024-06-13T17:37:15Z

Deploying ddev-com-front-end with Cloudflare Pages

Latest commit:	`79f80da`
Status:	✅ Deploy successful!
Preview URL:	https://673969e4.ddev-com-front-end.pages.dev
Branch Preview URL:	https://20240613-mariadb.ddev-com-front-end.pages.dev

View logs

rpkoller

Just a few small nitpicks and suggestions. overall the article is good and helpful!

rpkoller · 2024-06-13T18:08:20Z

src/content/blog/mariadb-dump-breaking-change.md

+
+You can read the details in the innocently titled article [MariaDB Dump File Compatibility Change](https://mariadb.org/mariadb-dump-file-compatibility-change/)
+
+## What does it mean To my DDEV projects?


Suggested change

## What does it mean To my DDEV projects?

## What does it mean to my DDEV projects?

rpkoller · 2024-06-13T18:18:47Z

src/content/blog/mariadb-dump-breaking-change.md

+
+### DDEV v1.23.1
+
+If you are using DDEV v1.23.1, we mitigated this problem at some levels by updating the DDEV v1.23.1 `ddev-dbserver` image. This solved a number of problems related to `ddev import-db` and `ddev export-db` because the format used was the new (breaking-change) MariaDB format. If you see this on `ddev import-db` or `ddev export-db` you can update to the newer version using the appropriate command below:


Suggested change

If you are using DDEV v1.23.1, we mitigated this problem at some levels by updating the DDEV v1.23.1 `ddev-dbserver` image. This solved a number of problems related to `ddev import-db` and `ddev export-db` because the format used was the new (breaking-change) MariaDB format. If you see this on `ddev import-db` or `ddev export-db` you can update to the newer version using the appropriate command below:

If you are already on DDEV v1.23.1, we've mitigated this problem to a certain extent by updating the `ddev-dbserver` image for this release. This solved a number of problems related to `ddev import-db` and `ddev export-db` because the format used was the new MariaDB format containing the breaking change. If you see this on `ddev import-db` or `ddev export-db` you can update to the newer version using the appropriate command below:

And what does "if you see this" refer to? to me it is not clear at all. i thought the snippet underneath are the instructions for updating to the newer version?

And what does "if you see this" refer to?

If you see the disaster in importing.

src/content/blog/mariadb-dump-breaking-change.md

rpkoller · 2024-06-13T18:23:38Z

src/content/blog/mariadb-dump-breaking-change.md

+We think we have worked around the majority of these cases in DDEV v1.23.2, see below.
+
+But:
+


Suggested change

We think we have worked around the majority of these cases in DDEV v1.23.2, see below.

But:

We think we have worked around the majority of these cases in DDEV v1.23.2, see the next section.

But before, be aware:

Suggested change

We think we have worked around the majority of these cases in DDEV v1.23.2, see below.

But:

We think we have worked around the majority of these cases in DDEV v1.23.2 (see the [next section](#what-has-ddev-done-to-mitigate-the-damage-inv1232)).

However, be aware:

src/content/blog/mariadb-dump-breaking-change.md

rpkoller · 2024-06-13T18:40:46Z

src/content/blog/mariadb-dump-breaking-change.md

+
+`/*!999999\- enable the sandbox mode */`
+
+This directive/content is incompatible with all versions of the `mysql` or `mariadb` database client from all vendors from before that May 17, 2024. 


Suggested change

This directive/content is incompatible with all versions of the `mysql` or `mariadb` database client from all vendors from before that May 17, 2024.

This directive is incompatible with all versions of the `mysql` or `mariadb` database client from all vendors prior May 17, 2024.

not sure if the slash content is necessary? content confused me more than that it explained things. is it content or a directive or both? personally i would stick to just directive?

from all vendors prior to May 17, 2024

or you could just go with

from all vendors before May 17, 2024

I didn't even know before that mysqldump in MariaDB context is just a symlink to mariadb-dump, or that MariaDB has been rebranding all of its tools. So that's why I used the slash all the time.

10.4 was a symlink to mariadb-dump. 10.5+ was a symlink the other way. As incompatibilities slowly creap in its important for users to know difference.

I don't understand your point @grooverdan , but a PR to this would be welcome. The current situation (mariadb 10.11 for example, is that mysqldump is a symlink to mariadb-dump:

$ mysql --version mysql Ver 15.1 Distrib 10.11.8-MariaDB, for debian-linux-gnu (aarch64) using EditLine wrapper rfay@d10-db:~$ ls -l $(which mysqldump) lrwxrwxrwx 1 root root 12 May 10 23:02 /usr/bin/mysqldump -> mariadb-dump

src/content/blog/mariadb-dump-breaking-change.md

rpkoller · 2024-06-13T18:50:06Z

src/content/blog/mariadb-dump-breaking-change.md

+  - DevOps
+---
+
+## What happened with MariaDB and MysqlDump?


Suggested change

## What happened with MariaDB and MysqlDump?

## What happened with MariaDB and MySQL Dump?

since later in the article it is referred to mariadb-dump and mysqldump it is probably better it use the correct word mark for MySQL since isnt referring to mariadb and mysqldump but to mariadb dump and mysql dump?

stasadev

Good article!
I noticed a few mistakes that @rpkoller has already fixed (thanks!), but luckily I didn't finish my review before him, so we avoided conflicts in the suggestions.

Co-authored-by: Ralf Koller <1665422+rpkoller@users.noreply.github.com>

rfay · 2024-06-13T19:47:09Z

Thanks for your suggestions!

marklabrecque · 2024-06-14T16:53:29Z

I reviewed this and it makes sense to me as well. Thanks everyone!

rfay added 3 commits June 13, 2024 10:58

Initial start

7ef2362

updated

176820b

near finished

e259b7c

rfay requested a review from stasadev June 13, 2024 17:39

pacify linter

826babb

rfay mentioned this pull request Jun 13, 2024

ddev import-db fails with "Error: Unknown command '\-'" because of new directive in mariadb-dump output ddev/ddev#6249

Closed

rfay added 2 commits June 13, 2024 11:56

Fix typo

b799718

use proper category

07a5dab

rfay requested a review from rpkoller June 13, 2024 17:58

rfay added 2 commits June 13, 2024 12:34

lower-case to

8ab0e78

full info about issue

eedba46

rpkoller reviewed Jun 13, 2024

View reviewed changes

stasadev approved these changes Jun 13, 2024

View reviewed changes

rfay and others added 4 commits June 13, 2024 13:36

Apply suggestions from code review, thanks

ee64e4b

Co-authored-by: Ralf Koller <1665422+rpkoller@users.noreply.github.com>

Suggestions from several people, thanks

efc53d2

@gilzow suggestions, thanks

f826354

More @gilzow suggestions thanks

79f80da

rfay merged commit e8369fd into main Jun 14, 2024
2 checks passed

rfay deleted the 20240613_mariadb branch June 14, 2024 02:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blog: MariaDB breaking change in dump format #210

Blog: MariaDB breaking change in dump format #210

rfay commented Jun 13, 2024 •

edited

Loading

cloudflare-pages bot commented Jun 13, 2024 •

edited

Loading

rpkoller left a comment

rpkoller Jun 13, 2024

rpkoller Jun 13, 2024

rfay Jun 13, 2024

rpkoller Jun 13, 2024

gilzow Jun 13, 2024

rpkoller Jun 13, 2024

gilzow Jun 13, 2024

rfay Jun 13, 2024

grooverdan Jun 18, 2024

rfay Jun 19, 2024

rpkoller Jun 13, 2024

stasadev left a comment

rfay commented Jun 13, 2024

marklabrecque commented Jun 14, 2024 •

edited

Loading


		You can read the details in the innocently titled article [MariaDB Dump File Compatibility Change](https://mariadb.org/mariadb-dump-file-compatibility-change/)

		## What does it mean To my DDEV projects?


		### DDEV v1.23.1

		If you are using DDEV v1.23.1, we mitigated this problem at some levels by updating the DDEV v1.23.1 `ddev-dbserver` image. This solved a number of problems related to `ddev import-db` and `ddev export-db` because the format used was the new (breaking-change) MariaDB format. If you see this on `ddev import-db` or `ddev export-db` you can update to the newer version using the appropriate command below:

		We think we have worked around the majority of these cases in DDEV v1.23.2, see below.

		But:

-We think we have worked around the majority of these cases in DDEV v1.23.2, see below.
-But:
+We think we have worked around the majority of these cases in DDEV v1.23.2, see the next section.
+But before, be aware:

-We think we have worked around the majority of these cases in DDEV v1.23.2, see below.
-But:
+We think we have worked around the majority of these cases in DDEV v1.23.2 (see the [next section](#what-has-ddev-done-to-mitigate-the-damage-inv1232)).
+However, be aware:


		`/!999999\- enable the sandbox mode /`

		This directive/content is incompatible with all versions of the `mysql` or `mariadb` database client from all vendors from before that May 17, 2024.

	This directive/content is incompatible with all versions of the `mysql` or `mariadb` database client from all vendors from before that May 17, 2024.
	This directive is incompatible with all versions of the `mysql` or `mariadb` database client from all vendors prior May 17, 2024.

	## What happened with MariaDB and MysqlDump?
	## What happened with MariaDB and MySQL Dump?

Blog: MariaDB breaking change in dump format #210

Blog: MariaDB breaking change in dump format #210

Conversation

rfay commented Jun 13, 2024 • edited Loading

The Issue

cloudflare-pages bot commented Jun 13, 2024 • edited Loading

Deploying ddev-com-front-end with Cloudflare Pages

rpkoller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stasadev left a comment

Choose a reason for hiding this comment

rfay commented Jun 13, 2024

marklabrecque commented Jun 14, 2024 • edited Loading

rfay commented Jun 13, 2024 •

edited

Loading

cloudflare-pages bot commented Jun 13, 2024 •

edited

Loading

marklabrecque commented Jun 14, 2024 •

edited

Loading