Skip to content

Commit

Permalink
build: update images to get get php8.3.0 and related new packages (#5574
Browse files Browse the repository at this point in the history
)
  • Loading branch information
rfay committed Nov 27, 2023
1 parent b396c9d commit 61d5490
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions containers/ddev-php-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ ENV php81_amd64=$php80_amd64
ENV php81_arm64=$php81_amd64
ENV php82_amd64=$php81_amd64
ENV php82_arm64=$php82_amd64
# php8.3 is still missing apcu, imagick, memcached, redis, uploadprogress, xdebug, xhprof, xmlrpc
ENV php83_amd64="bcmath bz2 curl cli common fpm gd intl ldap mbstring mysql opcache pgsql readline soap sqlite3 xml zip"
# php8.3 is still missing memcached redis xdebug
ENV php83_amd64="apcu bcmath bz2 curl cli common fpm gd imagick intl ldap mbstring mysql opcache pgsql readline soap sqlite3 uploadprogress xhprof xml xmlrpc zip"
ENV php83_arm64=$php83_amd64

RUN for v in $PHP_VERSIONS; do \
Expand Down
4 changes: 2 additions & 2 deletions containers/ddev-webserver/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
### ---------------------------ddev-webserver-base--------------------------------------
### Build ddev-php-base from ddev-webserver-base
### ddev-php-base is the basic of ddev-php-prod
### and ddev-webserver-* (For DDEV-Local)
FROM ddev/ddev-php-base:20231126_php8.3_fix as ddev-webserver-base
### and ddev-webserver-* (For DDEV local usage)
FROM ddev/ddev-php-base:v1.22.5 as ddev-webserver-base

ENV BACKDROP_DRUSH_VERSION=1.4.0
ENV DEBIAN_FRONTEND=noninteractive
Expand Down
3 changes: 1 addition & 2 deletions pkg/ddevapp/ddevapp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1090,8 +1090,7 @@ func TestDdevXhprofEnabled(t *testing.T) {
// Does not work with php5.6 anyway (SEGV), for resource conservation
// skip older unsupported versions
phpKeys := []string{}
// TODO: Re-enable 8.3 when it's available
exclusions := []string{"5.6", "7.0", "7.1", "7.2", "7.3", "7.4", "8.0", "8.3"}
exclusions := []string{"5.6", "7.0", "7.1", "7.2", "7.3", "7.4", "8.0"}
for k := range nodeps.ValidPHPVersions {
if !nodeps.ArrayContainsString(exclusions, k) {
phpKeys = append(phpKeys, k)
Expand Down
2 changes: 1 addition & 1 deletion pkg/versionconstants/versionconstants.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var AmplitudeAPIKey = ""
var WebImg = "ddev/ddev-webserver"

// WebTag defines the default web image tag
var WebTag = "20231126_php8.3_fix" // Note that this can be overridden by make
var WebTag = "v1.22.5-rc2" // Note that this can be overridden by make

// DBImg defines the default db image used for applications.
var DBImg = "ddev/ddev-dbserver"
Expand Down

0 comments on commit 61d5490

Please sign in to comment.