Skip to content

Commit

Permalink
Fix case of Sequel Pro.app, fixes #969 (#973)
Browse files Browse the repository at this point in the history
  • Loading branch information
@rfay
rfay committed Jul 5, 2018
1 parent 05111dc commit ccedee3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/ddev/cmd/sequelpro.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

// SequelproLoc is where we expect to find the sequel pro.app
// It's global so it can be mocked in testing.
var SequelproLoc = "/Applications/sequel pro.app"
var SequelproLoc = "/Applications/Sequel Pro.app"

This comment has been minimized.

Sign in to view

Copy link
@jdoubleu

jdoubleu Jul 6, 2018

Contributor

What if, for some reason, the app was installed/saved in lower case?
Or if it was put in another location (e.g. /Users/john/Applications)?

Due to the fact, that you are using the open command (see https://github.com/drud/ddev/blob/ccedee37bbb2a960b346be5c3a22cabdb17fc5d6/cmd/ddev/cmd/sequelpro.go#L88), I'd recommend to use the -a option:

open -a Sequel\ Pro

This way macOS will deal with case-sensitivity and different locations.

// DdevSequelproCmd represents the sequelpro command
var DdevSequelproCmd = &cobra.Command{
Expand Down

0 comments on commit ccedee3

Please sign in to comment.