Skip to content

Commit

Permalink
Use recent phpmyadmin version (4.9) and stop using drud variant (#2010)
Browse files Browse the repository at this point in the history
* Remove ddev-specific PHPMyAdmin
* Change to use upstream PHPMyAdmin instead of ddev-specific
* Add test to make sure PHPMyAdmin and MailHog are working
  • Loading branch information
thomaskieslich authored and rfay committed Dec 24, 2019
1 parent f4fee46 commit d9b3727
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 329 deletions.
12 changes: 0 additions & 12 deletions containers/phpmyadmin/.gitignore

This file was deleted.

6 changes: 0 additions & 6 deletions containers/phpmyadmin/Dockerfile

This file was deleted.

233 changes: 0 additions & 233 deletions containers/phpmyadmin/LICENSE

This file was deleted.

55 changes: 0 additions & 55 deletions containers/phpmyadmin/Makefile

This file was deleted.

3 changes: 0 additions & 3 deletions containers/phpmyadmin/README.md

This file was deleted.

2 changes: 0 additions & 2 deletions containers/phpmyadmin/test/README.md

This file was deleted.

16 changes: 0 additions & 16 deletions containers/phpmyadmin/test/containercheck.sh

This file was deleted.

7 changes: 7 additions & 0 deletions pkg/ddevapp/ddevapp_test.go
Expand Up @@ -957,6 +957,12 @@ func TestDdevFullSiteSetup(t *testing.T) {

err = app.Start()
assert.NoError(err)

// Validate PHPMyAdmin is working and database named db is present
_, _ = testcommon.EnsureLocalHTTPContent(t, app.GetHTTPURL()+":8036/tbl_create.php?server=1&db=db", "Table name:")
// Validate MailHog is working and "connected"
_, _ = testcommon.EnsureLocalHTTPContent(t, app.GetHTTPURL()+":8025/#", "Connected")

settingsLocation, err := app.DetermineSettingsPathLocation()
assert.NoError(err)
assert.Equal(filepath.Dir(settingsLocation), filepath.Dir(app.SiteSettingsPath))
Expand Down Expand Up @@ -1011,6 +1017,7 @@ func TestDdevFullSiteSetup(t *testing.T) {
runTime()
switchDir()
}
fmt.Print()
}

// TestDdevRestoreSnapshot tests creating a snapshot and reverting to it. This runs with Mariadb 10.2
Expand Down
4 changes: 2 additions & 2 deletions pkg/version/version.go
Expand Up @@ -58,10 +58,10 @@ var DBImg = "drud/ddev-dbserver"
var BaseDBTag = "v1.12.0"

// DBAImg defines the default phpmyadmin image tag used for applications.
var DBAImg = "drud/phpmyadmin"
var DBAImg = "phpmyadmin/phpmyadmin"

// DBATag defines the default phpmyadmin image tag used for applications.
var DBATag = "v1.12.0" // Note that this can be overridden by make
var DBATag = "4.9" // Note that this can be overridden by make

// BgsyncImg defines the default bgsync image tag used for applications.
var BgsyncImg = "drud/ddev-bgsync"
Expand Down

0 comments on commit d9b3727

Please sign in to comment.