fix: remove redundant chown in ddev-webserver start.sh, for #4942 (#5686

) [skip ci]
ddev · Feb 5, 2024 · f15cf72 · f15cf72
1 parent e6ba525
commit f15cf72
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/containers/ddev-webserver/ddev-webserver-base-scripts/start.sh b/containers/ddev-webserver/ddev-webserver-base-scripts/start.sh
@@ -116,9 +116,6 @@ if [ -d /mnt/ddev_config/.homeadditions ]; then
 fi
 
 # It's possible CAROOT does not exist or is not writeable (if host-side mkcert -install not run yet)
-# TODO: We shouldn't have to chown ddev-global-cache here as it's done by app.Start. However, in non-ddev
-# context it may still have to be done.
-sudo mkdir -p ${CAROOT} && sudo chown -R "$(id -u):$(id -g)" /mnt/ddev-global-cache/
 # This will install the certs from $CAROOT (/mnt/ddev-global-cache/mkcert)
 # It also creates them if they don't already exist
 if [ ! -f  "${CAROOT}/rootCA.pem" ]; then

diff --git a/pkg/versionconstants/versionconstants.go b/pkg/versionconstants/versionconstants.go
@@ -15,7 +15,7 @@ var AmplitudeAPIKey = ""
 var WebImg = "ddev/ddev-webserver"
 
 // WebTag defines the default web image tag
-var WebTag = "20240123_jonnitto_js_mimetypes" // Note that this can be overridden by make
+var WebTag = "20240104_redundant_chown" // Note that this can be overridden by make
 
 // DBImg defines the default db image used for applications.
 var DBImg = "ddev/ddev-dbserver"