Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composerto hook commands #1321

Closed
spoonerWeb opened this issue Dec 7, 2018 · 1 comment · Fixed by #1634
Closed

Add composerto hook commands #1321

spoonerWeb opened this issue Dec 7, 2018 · 1 comment · Fixed by #1634
Assignees
@andrewfrench

Comments

@spoonerWeb
Copy link
Contributor

Describe the solution you'd like
As it's now possible to use ddev composer, it would be nice to add it as a hook as well, like:

hooks:
  post-start:
    composer: install
    exec: ...

What do you think?
@rfay
Copy link
Member

rfay commented Dec 7, 2018

Yup, you're definitely right! Thanks.

@andrewfrench andrewfrench self-assigned this Dec 13, 2018
@rfay rfay changed the title Add composerto hooks Add composerto hook commands May 30, 2019
This was referenced May 30, 2019
Closed
Merged
rfay added a commit that referenced this issue Jun 24, 2019
@rfay
Rethink hooks and tasks, for #1372, fixes #1321, fixes #1071, fixes #…
6ba9fd6 
…1038 (#1634)

* Switch to yaml v3
* Add composer task
* Add multiple pre- and post- hooks
* Allow exec hook to specify container to act on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewfrench andrewfrench

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rethink hooks and tasks, for #1372, fixes #1321, fixes #1071, fixes #1038 rfay/ddev
3 participants
@rfay @spoonerWeb @andrewfrench