Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom command error handling - check for running project or service #1716

Closed
andrewfrench opened this issue Jul 19, 2019 · 1 comment

Comments

@andrewfrench
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When a custom command targets a non-running container, the error is fairly opaque:

Failed to run <cmd> : failed to load any docker-compose.*y*l files: <nil>

Describe the solution you'd like
An error message that describes the issue more generally:

Failed to run <cmd>: <project> is not running

@rfay
Copy link
Member

rfay commented Jul 19, 2019

Thanks for this! Maybe can clean up the similar stuff that comes out when you stop an already-stopped project.

Another approach on this issue is to not run custom commands at all if the project isn't started?

@rfay rfay added this to the v1.10 milestone Jul 19, 2019
@rfay rfay changed the title Improve custom command error handling Improve custom command error handling - check for running project or service Jul 19, 2019
@rfay rfay closed this as completed in ab3de84 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants