Take correct action on custom commands if project not running, fixes #1716 #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20190730_custom_command_not_running
branch
from
3d03829
to
738dce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
#1716 points out that custom command handling when the project is not running is really ugly; it tries to take action, but finds no container to execute in.
How this PR Solves The Problem:
Manual Testing Instructions:
ddev mysqlwith project stopped.phpstormcommand bycd .ddev/commands/host && ln -s phpstorm.example phpstormandddev phpstorm. It should start the project first. mysqlworkbench is more fun with this, because it actually wants the mysqlserver running, but it runs on the host.Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: